Skip to content

Disable flaky remote tests in dist_autograd_test #28920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disable flaky remote tests in dist_autograd_test #28920

wants to merge 1 commit into from

Conversation

@mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Oct 30, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18233625

mrshenli added a commit that referenced this pull request Oct 30, 2019
@mrshenli
Disable flaky remote tests in dist_autograd_test
8f46505 
ghstack-source-id: c9174f6
Pull Request resolved: #28920
@rohan-varma rohan-varma self-requested a review October 30, 2019 22:08
rohan-varma
rohan-varma approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohan-varma
Copy link
Contributor

rohan-varma commented Oct 30, 2019 •
edited
Loading

It looks like test_py_built_in rpc test is also flaky (https://app.circleci.com/jobs/github/pytorch/pytorch/3409933), should we disable that as well? I created #28932 to track this failure.

@mrshenli mrshenli mentioned this pull request Oct 30, 2019
Closed
@mrshenli
Copy link
Contributor Author

Yes, let's disable that and #28928 for test_backward_autograd_engine_error. Have we made any changes to RPC core recently?

@mrshenli
Copy link
Contributor Author

The failed test test_trainer_ps has already been disabled on master.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 64c7ac2.

This was referenced Oct 31, 2019
Closed
Closed
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/35/head branch November 3, 2019 15:15
@mrshenli mrshenli mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rohan-varma rohan-varma rohan-varma approved these changes

@pritamdamania87 pritamdamania87 pritamdamania87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrshenli @rohan-varma @facebook-github-bot @pritamdamania87 @mruberry