[JIT] Refactor iterables #29138
Closed
[JIT] Refactor iterables #29138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 4, 2019 10:29
ghstack-source-id: e3cf348 Pull Request resolved: pytorch#28296
Refactor list comprehensions so they go through the same path as other for loops, making List Comprehensions work with modulelists, also fixing pytorch#27255 [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
driazati
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor list comprehensions so they go through the same path as other for loops, making List Comprehensions work with modulelists, also fixing #27255
Replacing #28296 which was gh-poisoned and previously accepted.