Skip to content

[rpc] skip additional flaky tests in rpc #29157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[rpc] skip additional flaky tests in rpc #29157

wants to merge 4 commits into from

Conversation

@rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Nov 4, 2019 •
edited
Loading

Stack from ghstack:

As reported, these tests are flaky and time out. Skip them
while we investigate further.See #29156, #29150, #29117, #29212 for flakiness reports.

This is definitely starting to get whack-a-mole-y, it seems that the case probably is all rpc tests are flaky due to an underlying bug.

Differential Revision: D18309204

@rohan-varma
[rpc] skip additional flaky tests in rpc on ASAN
2074628 
As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further.

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)

[ghstack-poisoned]
@rohan-varma
Update on "[rpc] skip additional flaky tests in rpc on ASAN"
db6bd32 
As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further.

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)

[ghstack-poisoned]
@rohan-varma rohan-varma requested a review from aazzolini November 4, 2019 22:29
rohan-varma added a commit that referenced this pull request Nov 4, 2019
@rohan-varma
[rpc] skip additional flaky tests in rpc on ASAN
e2bea78 
Pull Request resolved: #29157

As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further.
ghstack-source-id: 93224923

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)
@rohan-varma
Update on "[rpc] skip additional flaky tests in rpc on ASAN"
90fa489 
As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further. See #29156, #29150, #29117 for flakiness reports.

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)

[ghstack-poisoned]
@rohan-varma rohan-varma changed the title [rpc] skip additional flaky tests in rpc on ASAN [rpc] skip additional flaky tests in rpc Nov 5, 2019
@rohan-varma
Update on "[rpc] skip additional flaky tests in rpc"
edb11b3 
As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further. See #29156, #29150, #29117 for flakiness reports.

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)

[ghstack-poisoned]
rohan-varma added a commit that referenced this pull request Nov 5, 2019
@rohan-varma
[rpc] skip additional flaky tests in rpc on ASAN
67bbde5 
Pull Request resolved: #29157

As reported, these tests are flaky and time out under ASAN. Skip them
while we investigate further.
ghstack-source-id: 93287663

Differential Revision: [D18309204](https://our.internmc.facebook.com/intern/diff/D18309204/)
mrshenli
mrshenli approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As many RRef tests are becoming flaky, I feel this might relate to the recent changes on to_here() and wait()

mrshenli
mrshenli reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#29069 should be the fix for test_multi_py_udf_remote and test_py_rref_args_user_share

@mrshenli mrshenli mentioned this pull request Nov 5, 2019
Closed
@rohan-varma
Copy link
Contributor Author

rohan-varma commented Nov 5, 2019 •
edited
Loading

CI's failure is unrelated, will land this:

Nov 05 19:27:31 Can NOT find backward compatible schemas after changes for schema aten::thnn_conv3d.out(Tensor self, Tensor weight, int[3] kernel_size, Tensor? bias=None, int[3] stride=[1, 1, 1], int[3] padding=[0, 0, 0], *, Tensor(a!) out) -> (Tensor(a!)) from the following candidates:
Nov 05 19:27:31 [
Nov 05 19:27:31 
Nov 05 19:27:31 ]
``

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 003cb85.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/28/head branch November 9, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

+1 more reviewer

@aazzolini aazzolini aazzolini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rohan-varma @facebook-github-bot @mrshenli @aazzolini @mruberry