Skip to content

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Nov 5, 2019

Stack from ghstack:

Differential Revision: D18329308

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are fine but they are not the same as the old boxed fallback tests, which showed you how to use backend fallback to do something more similar to what you /actually/ want to do (fallthrough to the underlying kernel, and do some other stuff along the way.)

@ezyang
Copy link
Contributor

ezyang commented Nov 5, 2019

(So, I'm not blocking landing this PR, but I don't think @mcarilli will really be satisfied by these tests.)

smessmer added a commit that referenced this pull request Nov 6, 2019
Pull Request resolved: #29214

-
ghstack-source-id: 93345601

Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
smessmer added a commit that referenced this pull request Nov 6, 2019
Pull Request resolved: #29214

-
ghstack-source-id: 93383485

Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
smessmer added a commit that referenced this pull request Nov 6, 2019
Pull Request resolved: #29214

-
ghstack-source-id: 93389158

Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
This was referenced Nov 12, 2019
@smessmer
Copy link
Contributor Author

@ezyang @mcarilli added those ones in #29682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants