-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Test cases for backend fallback kernels #29214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) ghstack-source-id: 93287837 Pull Request resolved: #29214
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are fine but they are not the same as the old boxed fallback tests, which showed you how to use backend fallback to do something more similar to what you /actually/ want to do (fallthrough to the underlying kernel, and do some other stuff along the way.)
|
(So, I'm not blocking landing this PR, but I don't think @mcarilli will really be satisfied by these tests.) |
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
Pull Request resolved: #29214 - ghstack-source-id: 93345601 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
Pull Request resolved: #29214 - ghstack-source-id: 93383485 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
Pull Request resolved: #29214 - ghstack-source-id: 93389158 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
Stack from ghstack:
Differential Revision: D18329308