NHWC support in cuDNN BatchNorm & Conv2d #29361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the 9a9bb44 Fixing the broken case which reverts the previous commit. details about fix: modified: aten/src/ATen/native/Convolution.cpp called contiguous on 3D input tensor. This avoids the code path to accidentally recognize the input as channel_last stride, due to unsqueezing of permuted 3d tensor.
facebook-github-bot
added
the
oncall: jit
|
The 3 line fix is here: https://github.com/pytorch/pytorch/pull/29361/files#diff-57ac615408468d3c7a461e505581bea3R568-R571 The previous failing case is actually still a legit nhwc case in cudnn. It's failing some trivial dimension checks. I'm working with cudnn team on fixing that. |
VitalyFedyunin
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 7, 2019
Summary: This reverts the 9a9bb448ee49a1493f22bbbeed4af92b1364fce9 Fixing the broken case which reverts the previous commit. details about fix: modified: aten/src/ATen/native/Convolution.cpp called contiguous on 3D input tensor. This avoids the code path to accidentally recognize the input as channel_last stride, due to unsqueezing of permuted 3d tensor. Pull Request resolved: pytorch/pytorch#29361 Differential Revision: D18371964 Pulled By: VitalyFedyunin fbshipit-source-id: a5985f4687b37e183649fa35b8ccdb50368ebfdf
|
@VitalyFedyunin merged this pull request in fdab1cf. |
VitalyFedyunin
added a commit
to VitalyFedyunin/pytorch
that referenced
this pull request
Nov 18, 2019
This PR was bisected as the reason of HRNet becomeing unstable. We are keeping inversigation, meanwhile I will revert it. This reverts commit fdab1cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the 9a9bb44
Fixing the broken case which reverts the previous commit.
details about fix:
modified: aten/src/ATen/native/Convolution.cpp
called contiguous on 3D input tensor. This avoids the code path to accidentally
recognize the input as channel_last stride, due to unsqueezing of permuted 3d
tensor.