Re-enable TestNamedTensor.test_big_tensor_repr #29407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #27753. The bug was that random tensors print subtly differently. This causes the "names=" tag to appear in slightly different places; sometimes it is on the same line as the data, sometimes it is on different lines. For this test, we wanted to know the following: - printing a big named tensor's repr doesn't crash - a big named tensor's repr shows the names This PR changes the test to check those two things. Test Plan: - run existing tests
zou3519
added a commit
that referenced
this pull request
Nov 7, 2019
Fixes #27753. The bug was that random tensors print subtly differently. This causes the "names=" tag to appear in slightly different places; sometimes it is on the same line as the data, sometimes it is on different lines. For this test, we wanted to know the following: - printing a big named tensor's repr doesn't crash - a big named tensor's repr shows the names This PR changes the test to check those two things. Test Plan: - run existing tests ghstack-source-id: ae5d443 Pull Request resolved: #29407
nairbv
reviewed
Nov 8, 2019
test/test_namedtensor.py
Outdated
| expected = "{}, names={})".format(repr(unnamed_tensor)[:-1], named_tensor.names) | ||
| self.assertEqual(repr(named_tensor), expected) | ||
| names_tag = 'names={}'.format(named_tensor.names) | ||
| self.assertTrue(names_tag in repr(named_tensor)) |
There was a problem hiding this comment.
nit: we could use assertRegexpMatches so that any error message would print both of the non-matching strings
There was a problem hiding this comment.
EDIT: That's a good idea, let me try that.
There was a problem hiding this comment.
It turns out there is something called assertIn that solves this problem
nairbv
approved these changes
Nov 8, 2019
Fixes #27753. The bug was that random tensors print subtly differently. This causes the "names=" tag to appear in slightly different places; sometimes it is on the same line as the data, sometimes it is on different lines. For this test, we wanted to know the following: - printing a big named tensor's repr doesn't crash - a big named tensor's repr shows the names This PR changes the test to check those two things. Test Plan: - run existing tests
zou3519
added a commit
that referenced
this pull request
Nov 11, 2019
Fixes #27753. The bug was that random tensors print subtly differently. This causes the "names=" tag to appear in slightly different places; sometimes it is on the same line as the data, sometimes it is on different lines. For this test, we wanted to know the following: - printing a big named tensor's repr doesn't crash - a big named tensor's repr shows the names This PR changes the test to check those two things. Test Plan: - run existing tests ghstack-source-id: 88ca7b3 Pull Request resolved: #29407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #27753.
The bug was that random tensors print subtly differently. This causes
the "names=" tag to appear in slightly different places; sometimes it is
on the same line as the data, sometimes it is on different lines.
For this test, we wanted to know the following:
This PR changes the test to check those two things.
Test Plan:
Differential Revision: D18428657