-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove two unused TH definitions of rsqrt. #29688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but need to see all tests passing ( we are observing infrastructure problems ATM )
|
OK. Will rebase some time after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll take care of the merge when the CI is fixed and all test pass.
|
@pytorchbot retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VitalyFedyunin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@VitalyFedyunin merged this pull request in ce70583. |
Summary: Pull Request resolved: pytorch/pytorch#29688 Differential Revision: D18465222 Pulled By: VitalyFedyunin fbshipit-source-id: a33880db389b82a8242c79723830e0a3afd3d498
Summary: Pull Request resolved: pytorch#29688 Differential Revision: D18465222 Pulled By: VitalyFedyunin fbshipit-source-id: a33880db389b82a8242c79723830e0a3afd3d498
No description provided.