Skip to content

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Nov 12, 2019

No description provided.

@xuhdev xuhdev changed the title Remove two unused definitions of rsqrt. Remove two unused TH definitions of rsqrt. Nov 12, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@VitalyFedyunin VitalyFedyunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but need to see all tests passing ( we are observing infrastructure problems ATM )

@xuhdev
Copy link
Collaborator Author

xuhdev commented Nov 13, 2019

OK. Will rebase some time after

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll take care of the merge when the CI is fixed and all test pass.

@albanD
Copy link
Collaborator

albanD commented Nov 13, 2019

@pytorchbot retest this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitalyFedyunin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@VitalyFedyunin merged this pull request in ce70583.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Nov 15, 2019
Summary: Pull Request resolved: pytorch/pytorch#29688

Differential Revision: D18465222

Pulled By: VitalyFedyunin

fbshipit-source-id: a33880db389b82a8242c79723830e0a3afd3d498
csarofeen pushed a commit to mruberry/pytorch that referenced this pull request Nov 18, 2019
Summary: Pull Request resolved: pytorch#29688

Differential Revision: D18465222

Pulled By: VitalyFedyunin

fbshipit-source-id: a33880db389b82a8242c79723830e0a3afd3d498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants