Rename dist_autograd_context and dist_autograd_container. #29696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths distributed/autograd/context/dist_autograd_context.h and distributed/autograd/context/dist_autograd_container.h were repetitive. Therefore renaming these to distributed/autograd/context/context.h and distributed/autograd/context/container.h Differential Revision: [D18467624](https://our.internmc.facebook.com/intern/diff/D18467624/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 13, 2019
The paths distributed/autograd/context/dist_autograd_context.h and distributed/autograd/context/dist_autograd_container.h were repetitive. Therefore renaming these to distributed/autograd/context/context.h and distributed/autograd/context/container.h Differential Revision: [D18467624](https://our.internmc.facebook.com/intern/diff/D18467624/) ghstack-source-id: 93784971 Pull Request resolved: #29696
|
@pytorchbot retest this please |
pietern
reviewed
Nov 13, 2019
There was a problem hiding this comment.
The tests must pass before we can merge this, even if they look like transient errors.
LGTM otherwise. Thanks, @pritamdamania87!
The paths distributed/autograd/context/dist_autograd_context.h and distributed/autograd/context/dist_autograd_container.h were repetitive. Therefore renaming these to distributed/autograd/context/context.h and distributed/autograd/context/container.h Differential Revision: [D18467624](https://our.internmc.facebook.com/intern/diff/D18467624/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 13, 2019
Pull Request resolved: #29696 The paths distributed/autograd/context/dist_autograd_context.h and distributed/autograd/context/dist_autograd_container.h were repetitive. Therefore renaming these to distributed/autograd/context/context.h and distributed/autograd/context/container.h ghstack-source-id: 93850266 Differential Revision: [D18467624](https://our.internmc.facebook.com/intern/diff/D18467624/)
|
@pytorchbot retest this please |
1 similar comment
|
@pytorchbot retest this please |
|
It seems pythonbot does not trigger rerun on "/ Build Failed (pull_request)" and "/ Build Failed (push) ". I tried to rerun them manually on the following page, but still hit the same error: "- Workflows can't be executed on this repository. Please check your payment method or billing status." https://github.com/pytorch/pytorch/pull/29696/checks?check_run_id=301851237 Is submitting a new commit the only way to trigger those two ci tests, or can we ignore them? |
|
Just rebase to master. Or ignore them. |
ezyang
approved these changes
Nov 14, 2019
|
This pull request has been merged in 77bb41c. |
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
) Summary: Pull Request resolved: pytorch#29696 The paths distributed/autograd/context/dist_autograd_context.h and distributed/autograd/context/dist_autograd_container.h were repetitive. Therefore renaming these to distributed/autograd/context/context.h and distributed/autograd/context/container.h ghstack-source-id: 93850266 Test Plan: waitforbuildbot Differential Revision: D18467624 fbshipit-source-id: bbf3905396f553006851af296c880c1bd106ec47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The paths distributed/autograd/context/dist_autograd_context.h and
distributed/autograd/context/dist_autograd_container.h were repetitive.
Therefore renaming these to distributed/autograd/context/context.h and
distributed/autograd/context/container.h
Differential Revision: D18467624