[rpc] rename init_model_parallel to init_rpc #29762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename this API as discussed, since it's use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
requested review from
apaszke,
mrshenli and
pietern
as code owners
Rename this API as discussed, since it's use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
changed the title
rohan-varma
commented
Nov 13, 2019
| # Initialize ProcessGroup. | ||
| if dist.is_initialized(): | ||
| raise RuntimeError( | ||
| "Default process group must not be initialized before `init_model_parallel`." |
There was a problem hiding this comment.
removed backticks
Rename this API as discussed, since its use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 13, 2019
Pull Request resolved: #29762 Rename this API as discussed, since it's use cases extend beyond only model parallelism. ghstack-source-id: 93868097 Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/)
pritamdamania87
approved these changes
Nov 14, 2019
Rename this API as discussed, since its use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 14, 2019
Pull Request resolved: #29762 Rename this API as discussed, since it's use cases extend beyond only model parallelism. ghstack-source-id: 93880068 Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/)
zhaojuanmao
reviewed
Nov 14, 2019
I think we can rename it |
mrshenli
approved these changes
Nov 14, 2019
pietern
reviewed
Nov 14, 2019
torch/distributed/rpc/__init__.py
Outdated
| ): | ||
| r""" | ||
| Initializes model parallel primitives such as the local rpc agent | ||
| Initializes rpc primitives such as the local rpc agent |
There was a problem hiding this comment.
Nit for later fixup: capitalize RPC.
Rename this API as discussed, since its use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 15, 2019
Pull Request resolved: #29762 Rename this API as discussed, since it's use cases extend beyond only model parallelism. ghstack-source-id: 93974400 Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/)
Rename this API as discussed, since its use cases extend beyond only model parallelism. Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 15, 2019
Pull Request resolved: #29762 Rename this API as discussed, since it's use cases extend beyond only model parallelism. ghstack-source-id: 94020627 Differential Revision: [D18491743](https://our.internmc.facebook.com/intern/diff/D18491743/)
|
This pull request has been merged in 639133d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Rename this API as discussed, since its use cases extend beyond only
model parallelism.
Differential Revision: D18491743