Split module.cpp and export.cpp to support saving on mobile #29881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreiss
requested review from
apaszke,
ebetica,
goldsborough and
yf225
as code owners
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D18509296 |
yf225
reviewed
Nov 15, 2019
There was a problem hiding this comment.
Curious are the std::to_string changes meant to be part of another PR #29839 ?
There was a problem hiding this comment.
Yeah, I think that happened because it's a stacked diff in fbsource.
|
Are there any changes that don't just move code to a different file? |
smessmer
approved these changes
Nov 15, 2019
dreiss
force-pushed
the
export-D18509296
branch
from
7d955a8 to
75acb60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18509296 |
…29881) Summary: Pull Request resolved: pytorch#29881 Breaking these into separate files allows us to have three different builds: - Mobile inference-only. - Mobile with module saving. - Server with module saving and other export functions like ONNX. And this can be accomplished just by selecting which cpp files to compile, without setting any preprocessor flags. Test Plan: CI. Local mobile+saving build. Reviewed By: smessmer Differential Revision: D18509296 fbshipit-source-id: 151a8cca9a01ec9ccc42df060ff03885a4bcf515
dreiss
force-pushed
the
export-D18509296
branch
from
75acb60 to
a3984ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18509296 |
|
This pull request has been merged in fbcb88e. |
ljk53
added a commit
that referenced
this pull request
Nov 21, 2019
Summary: PR #29881 moved Module::save() methods to a separate source file and removed C10_MOBILE gating logic. Seems it should stay with export_module.cpp (which is in "NOT INTERN_BUILD_MOBILE" section). Otherwise it causes link error with build_mobile.sh. Test: - build locally - check CI [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Nov 21, 2019
Summary: PR #29881 moved Module::save() methods to a separate source file and removed C10_MOBILE gating logic. Seems it should stay with export_module.cpp (which is in "NOT INTERN_BUILD_MOBILE" section). Otherwise it causes link error with build_mobile.sh. Test: - build locally - check CI ghstack-source-id: 0485324 Pull Request resolved: #30221
ljk53
added a commit
that referenced
this pull request
Nov 22, 2019
… in cmake" Summary: PR #29881 moved Module::save() methods to a separate source file and removed C10_MOBILE gating logic. Seems it should stay with export_module.cpp (which is in "NOT INTERN_BUILD_MOBILE" section). Otherwise it causes link error with build_mobile.sh. Test: - build locally - check CI Differential Revision: [D18649234](https://our.internmc.facebook.com/intern/diff/D18649234) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 22, 2019
Summary: Pull Request resolved: #30221 PR #29881 moved Module::save() methods to a separate source file and removed C10_MOBILE gating logic. Seems it should stay with export_module.cpp (which is in "NOT INTERN_BUILD_MOBILE" section). Otherwise it causes link error with build_mobile.sh. Test: - build locally - check CI Test Plan: Imported from OSS Differential Revision: D18649234 Pulled By: ljk53 fbshipit-source-id: b6c90a532d191c41ce10c1047a869d8f73854c4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Breaking these into separate files allows us to have three different builds:
And this can be accomplished just by selecting which cpp files to compile,
without setting any preprocessor flags.
Test Plan: CI. Local mobile+saving build.
Differential Revision: D18509296