[jit] Add pickler support for Device #30131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds (un)pickling support for `c10::Device`. It also adds `torch.device` as a type annotation for device attributes.
facebook-github-bot
added
the
oncall: jit
|
Could we reduce forward-compat problems by splitting this into a reader change that we ship first, and a writer change that we ship second? |
|
This doesn't change any existing behavior (someone has to notice this feature and then go and try to serialize a |
zdevito
approved these changes
Dec 2, 2019
torch/csrc/jit/unpickler.cpp
Outdated
| stack_.emplace_back(c10::Device(device_string.toStringRef())); | ||
| }); | ||
| stack_.emplace_back(int64_t(globals_.size() - 1)); | ||
| return opcode; |
There was a problem hiding this comment.
The early returns that have accumulated in this branch of the switch statement should be cleaned up. It is not clear to me why some cases break, others early return, and some push the globals reference number into the stack. Ideally, nothing inside of the switch statement should be returning early. Perhaps put the global logic in its own function for clarity.
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: This PR adds (un)pickling support for `c10::Device`. It also adds `torch.device` as a type annotation for device attributes. ](https://our.intern.facebook.com/intern/diff/18664421/) Pull Request resolved: pytorch#30131 Pulled By: driazati Differential Revision: D18664421 fbshipit-source-id: 64378fb42b2d1bbe2bd86259e5ed10f24b5d1e49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (un)pickling support for
c10::Device. It also addstorch.deviceas a type annotation for device attributes.Differential Revision: D18664421