-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[quant][graphmode][refactor] Add registerQParams function #30552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Nov 28, 2019
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's what I asked for in previous review! Thanks, looks good!
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18818653](https://our.internmc.facebook.com/intern/diff/D18818653) [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18818653](https://our.internmc.facebook.com/intern/diff/D18818653) [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18818653](https://our.internmc.facebook.com/intern/diff/D18818653) [ghstack-poisoned]
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18818653](https://our.internmc.facebook.com/intern/diff/D18818653) [ghstack-poisoned]
This was referenced Dec 6, 2019
Summary: For upcoming changes to support quantizing shared class type Test Plan: . Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18818653](https://our.internmc.facebook.com/intern/diff/D18818653) [ghstack-poisoned]
|
This pull request has been merged in 4ed2eae. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30552 For upcoming changes to support quantizing shared class type Test Plan: . Imported from OSS Differential Revision: D18818653 fbshipit-source-id: 393a55db69b20a1c00ffa0157ab568cb097915b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
insert_quant_dequantpass support shared class types #30553 [quant][graphmode]insert_quant_dequantpass support shared class typesInsertQuantDeQuantHelper#30860 [quant][graphmode][refactor] Factor out getInvokedMethod inInsertQuantDeQuantHelpervalues_to_quantize_#30858 [quant][graphmode] Removevalues_to_quantize_Summary:
For upcoming changes to support quantizing shared class type
Test Plan:
.
Reviewers:
mvz
Subscribers:
Tasks:
Tags:
Differential Revision: D18818653