Wrap warning handler in a function to avoid siof #30800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: SparseNN benchmark crashed due to this. Wrap warning handler in a function to avoid siof. Test Plan: Tested locally, SparseNN benchmark no longer crashes. Differential Revision: D18826731 fbshipit-source-id: d2f20bc343bca3b061921acefe0af40cc4c8b62e
|
This pull request was exported from Phabricator. Differential Revision: D18826731 |
smessmer
approved these changes
Dec 5, 2019
|
This pull request has been merged in 9617d07. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30800 SparseNN benchmark crashed due to this. Wrap warning handler in a function to avoid siof. Test Plan: Tested locally, SparseNN benchmark no longer crashes. Reviewed By: yinghai Differential Revision: D18826731 fbshipit-source-id: 8fcab8a3f38cc20f775409c0686363af3c27d0a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SparseNN benchmark crashed due to this.
Wrap warning handler in a function to avoid siof.
Test Plan: Tested locally, SparseNN benchmark no longer crashes.
Differential Revision: D18826731