Add tracing support for optional Device and Layout #30979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
This was referenced Dec 9, 2019
Closed
Closed
izdeby
changed the title
izdeby
changed the title
|
Someone from JIT (e.g. @eellison should review this). |
eellison
approved these changes
Dec 10, 2019
| if (value.has_value()) { | ||
| detail::genericAddInput(n, static_cast<int64_t>(*value)); | ||
| } else { | ||
| Graph* g = n->owningGraph(); |
There was a problem hiding this comment.
It would be nice if you factored the 8 copy-pasta's of this three-line block into it's own function (i am one of those copy-paster's...)
This stack is a first step toward an effort to fix, clean up and simplify code generation logic. Please see the master [task](#30405) to see related discussions and all the known issues. Main focus of these changes is TensorOptions in code generation. Goals: - Remove TensorOptions from generated code wherever it's possible. Leave it only in python/C++ API layers. - Refactor TensorOptions logic to a single place. - Log all discovered issues. Non goals: - Fix Everything! - Remove all the hacks in code generation scripts. - Clean up and defector all code generation scripts. -------------- In this PR: Add tracing support for optional Device and Layout types. -------------- [ghstack-poisoned]
This stack is a first step toward an effort to fix, clean up and simplify code generation logic. Please see the master [task](#30405) to see related discussions and all the known issues. Main focus of these changes is TensorOptions in code generation. Goals: - Remove TensorOptions from generated code wherever it's possible. Leave it only in python/C++ API layers. - Refactor TensorOptions logic to a single place. - Log all discovered issues. Non goals: - Fix Everything! - Remove all the hacks in code generation scripts. - Clean up and defector all code generation scripts. -------------- In this PR: Add tracing support for optional Device and Layout types. -------------- Differential Revision: [D18912685](https://our.internmc.facebook.com/intern/diff/D18912685) [ghstack-poisoned]
ezyang
approved these changes
Dec 11, 2019
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30979 This stack is a first step toward an effort to fix, clean up and simplify code generation logic. �Please see the master [task](pytorch#30405) to see related discussions and all the known issues. Main focus of these changes is TensorOptions in code generation. Goals: - Remove TensorOptions from generated code wherever it's possible. Leave it only in python/C++ API layers. - Refactor TensorOptions logic to a single place. - Log all discovered issues. Non goals: - Fix Everything! - Remove all the hacks in code generation scripts. - Clean up and defector all code generation scripts. -------------- In this PR: Add tracing support for optional Device and Layout types. -------------- Test Plan: Imported from OSS Differential Revision: D18912685 Pulled By: izdeby fbshipit-source-id: 4a9514ce2eee0041f9bc96636d3ddb4f077675e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stack is a first step toward an effort to fix, clean up and simplify code generation logic. Please see the master task to see related discussions and all the known issues.
Main focus of these changes is TensorOptions in code generation.
Goals:
Non goals:
In this PR:
Add tracing support for optional Device and Layout types.
Stack from ghstack:
Differential Revision: D18912685