Skip to content

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Dec 10, 2019

Stack from ghstack:

Previously the profiler would think Tensors would require grad, even
when the no_grad flag is enabled during execution. This makes the profiling
and guards respect the no_grad flag, which eliminates extra differentiable
graphs that appear in the backward graph (where no_grad is typically enabled).

Differential Revision: D18915468

Previously the profiler would think Tensors would require grad, even
when the no_grad flag is enabled during execution. This makes the profiling
and guards respect the no_grad flag, which eliminates extra differentiable
graphs that appear in the backward graph (where no_grad is typically enabled).
@zdevito zdevito requested a review from apaszke as a code owner December 10, 2019 20:37
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 10, 2019
@zdevito zdevito requested a review from Krovatkin December 10, 2019 20:40
@kostmo
Copy link
Member

kostmo commented Dec 10, 2019

CircleCI build failures summary

As of commit 9fefea3:

  • 1/1 broken upstream at merge base cc31965 (see grid view)
    • You may want to rebase on the viable/strict branch (see its recency history):
      • Since your merge base is older than viable/strict, run these commands:
        git fetch viable/strict
        git rebase viable/strict
        
  • 0/1 failures introduced in this PR

Detailed failure analysis (WIP)

Here are the reasons each build failed:

1 failure recognized by patterns:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: Test (details)

Dec 10 17:23:30 s...Traceback (most recent call last):
Dec 10 17:23:30   File "test/run_test.py", line 456, in <module>
Dec 10 17:23:30     main()
Dec 10 17:23:30   File "test/run_test.py", line 449, in main
Dec 10 17:23:30     raise RuntimeError(message)
Dec 10 17:23:30 RuntimeError: test_quantized_nn_mods failed! Received signal: SIGSEGV
Dec 10 17:23:30 + cleanup
Dec 10 17:23:30 + retcode=1
Dec 10 17:23:30 + set +x

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

[jit] make profiling take no_grad flags into account

Previously the profiler would think Tensors would require grad, even
when the no_grad flag is enabled during execution. This makes the profiling
and guards respect the no_grad flag, which eliminates extra differentiable
graphs that appear in the backward graph (where no_grad is typically enabled).

gh-metadata: pytorch pytorch 31071 gh/zdevito/139/head
@facebook-github-bot
Copy link
Contributor

@zdevito merged this pull request in cc8d634.

@facebook-github-bot facebook-github-bot deleted the gh/zdevito/139/head branch December 21, 2019 15:17
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Pull Request resolved: pytorch#31071

Previously the profiler would think Tensors would require grad, even
when the no_grad flag is enabled during execution. This makes the profiling
and guards respect the no_grad flag, which eliminates extra differentiable
graphs that appear in the backward graph (where no_grad is typically enabled).

Test Plan: Imported from OSS

Differential Revision: D18915468

Pulled By: zdevito

fbshipit-source-id: 1ae816a16ab78ae5352825cc6b4a68ed7681a089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants