Skip to content

[v1.4.0 cherrypick] ONNX Interpolate Add Scales Params - 2 #31274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[v1.4.0 cherrypick] ONNX Interpolate Add Scales Params - 2 #31274

wants to merge 4 commits into from

Conversation

lara-hdr
Copy link
Contributor

The original PR is #28324

We hope we can cover torchvision models in PyTorch ONNX exporter with release 1.4. This PR is part of it.

cc: @houseroad

Lara added 2 commits December 13, 2019 16:51
ONNX Interpolate Add Scales Params (pytorch#28324)
116cf19 
Summary:
Fix for : pytorch#27176
Pull Request resolved: pytorch#28324

Reviewed By: hl475

Differential Revision: D18309133

Pulled By: houseroad

fbshipit-source-id: 348bb41393442c6b107d88fc2cd3224e0afa3ccf
update expect files
01ae0ca
@lara-hdr lara-hdr requested a review from apaszke as a code owner December 14, 2019 00:54
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 14, 2019
@kostmo
Copy link
Member

kostmo commented Dec 14, 2019 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 9fff611:

Commit 9fff611 was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 9 times.

@BowenBao
Copy link
Collaborator

@spandantiwari @houseroad @gchanan @lara-hdr
I'm taking over the PR since Lara is on vacation.
Submitted the change for naming changes, from scales_1 to scales_h, etc.

@lara-hdr
Copy link
Contributor Author

Thank you @BowenBao!
@gchanan, the PR is updated with the suggested change.

@gottbrath gottbrath requested a review from jamesr66a December 20, 2019 18:14
@gchanan
Copy link
Contributor

gchanan commented Dec 20, 2019

@BowenBao can you submit a patch against master with only the diff changes? That will be easier to review, and then we can just cherry-pick both PRs on top of each other from 1.4.

gchanan
gchanan reviewed Dec 20, 2019
View reviewed changes
aten/src/ATen/native/UpSample.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment looks out of date.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean False should be None? I don't have enough context here, but by looking at the code I think other than that the description is accurate. I would include this change if needed in the separate PR as well.

@BowenBao BowenBao mentioned this pull request Dec 20, 2019
Closed
@BowenBao BowenBao force-pushed the lahaidar/cherry_pick_PR_28324 branch from d638273 to 9fff611 Compare December 20, 2019 22:09
@BowenBao
Copy link
Collaborator

@BowenBao can you submit a patch against master with only the diff changes? That will be easier to review, and then we can just cherry-pick both PRs on top of each other from 1.4.

Submitted the separate PR against master #31526. And reverted these changes for this PR.

facebook-github-bot pushed a commit that referenced this pull request Jan 2, 2020
@BowenBao @facebook-github-bot
Renaming scales parameter for interpolate (#31526)
c4f10e0 
Summary:
PR separated from #31274.
Pull Request resolved: #31526

Reviewed By: zou3519

Differential Revision: D19221931

Pulled By: gchanan

fbshipit-source-id: 81958a9910867ac9d62f2b47abc49384526c4e51
gchanan pushed a commit to gchanan/pytorch that referenced this pull request Jan 2, 2020
@BowenBao @gchanan
Renaming scales parameter for interpolate (pytorch#31526)
cf13b2d 
Summary:
PR separated from pytorch#31274.
Pull Request resolved: pytorch#31526

Reviewed By: zou3519

Differential Revision: D19221931

Pulled By: gchanan

fbshipit-source-id: 81958a9910867ac9d62f2b47abc49384526c4e51
@zhangguanheng66 zhangguanheng66 added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 14, 2020
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
@BowenBao @facebook-github-bot
Renaming scales parameter for interpolate (pytorch#31526)
b736811 
Summary:
PR separated from pytorch#31274.
Pull Request resolved: pytorch#31526

Reviewed By: zou3519

Differential Revision: D19221931

Pulled By: gchanan

fbshipit-source-id: 81958a9910867ac9d62f2b47abc49384526c4e51
@peterjc123 peterjc123 closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan left review comments

@BowenBao BowenBao BowenBao left review comments

@apaszke apaszke Awaiting requested review from apaszke

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

Assignees

No one assigned

Labels

module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lara-hdr @kostmo @BowenBao @gchanan @zhangguanheng66 @facebook-github-bot @peterjc123 @pytorchbot