Skip to content

Conversation

archsyscall
Copy link
Contributor

In the long string, formalstring thinks it is good to have a name.

When using dict, literal is better for readability and faster than dict constructor.

I always appreciate your efforts in creating the world's best frameworks.

@kostmo
Copy link
Member

kostmo commented Dec 17, 2019

CircleCI build failures summary

As of commit 581a283:

  • 2/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

2 new failures recognized by patterns

The following build failures don't appear to be due to upstream breakage:

See CircleCI build pytorch_windows_test2 (1/2)

Step: "Test" (full log | pattern match details)

- cmake - cmake not installed. The package was not found with the source(s) listed.
 NOTE: When you specify explicit sources, it overrides default sources. 
If the package version is a prerelease and you didn't specify `--pre`, 
 the package may not be found. 
Please see https://chocolatey.org/docs/troubleshooting for more  
 assistance. 
 
Chocolatey installed 0/1 packages. 1 packages failed. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log). 
 
Failures 
 - cmake - cmake not installed. The package was not found with the source(s) listed. 
 Source(s): 'https://chocolatey.org/api/v2/' 
 NOTE: When you specify explicit sources, it overrides default sources. 
If the package version is a prerelease and you didn't specify `--pre`, 
 the package may not be found. 
Please see https://chocolatey.org/docs/troubleshooting for more  
 assistance. 

See CircleCI build pytorch_windows_test1 (2/2)

Step: "Test" (full log | pattern match details)

- cmake (exited 1) - cmake not installed. An error occurred during installation:
 Unable to resolve dependency 'cmake.install (= 3.16.1)'. 
cmake package files install completed. Performing other installation steps. 
The install of cmake was NOT successful. 
cmake not installed. An error occurred during installation: 
 Unable to resolve dependency 'cmake.install (= 3.16.1)'. 
 
Chocolatey installed 0/1 packages. 1 packages failed. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log). 
 
Failures 
 - cmake (exited 1) - cmake not installed. An error occurred during installation: 
 Unable to resolve dependency 'cmake.install (= 3.16.1)'. 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

@ngimel ngimel self-requested a review December 20, 2019 03:08
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 20, 2019
@ngimel
Copy link
Collaborator

ngimel commented Dec 20, 2019

Thank you for your PR!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in d770fbc.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
In the long string, formalstring thinks it is good to have a name.

When using dict, literal is better for readability and faster than dict constructor.

I always appreciate your efforts in creating the world's best frameworks.
Pull Request resolved: pytorch#31352

Differential Revision: D19191967

Pulled By: ngimel

fbshipit-source-id: 21f063b163b67de8cf9761a4db5991f74318e991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants