Test reading __cuda_array_interface__ inferred strides.
#31451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchanan
added a commit
that referenced
this pull request
Dec 19, 2019
💊 CircleCI build failures summary and remediationsAs of commit 92b8f5e: Waiting for builds of commit 92b8f5e This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
zou3519
approved these changes
Dec 19, 2019
| @unittest.skipIf(not TEST_CUDA, "No cuda") | ||
| @unittest.skipIf(not TEST_NUMBA_CUDA, "No numba.cuda") | ||
| def test_from_cuda_array_interface_inferred_strides(self): | ||
| """torch.as_tensor(numba_ary) should have correct inferred (contiguous) strides""" |
There was a problem hiding this comment.
Nit: I think numba_ary read better as numba_array; I haven't seen too many usages of "ary" to mean array in the past
There was a problem hiding this comment.
I agree -- I was just following the style of the rest of the test here (which seems useful, since this test should just be combined with others once we make the test less strict).
test/test_numba_integration.py
Outdated
| """torch.as_tensor(numba_ary) should have correct inferred (contiguous) strides""" | ||
| # This could, in theory, be combined with test_from_cuda_array_interface but that test | ||
| # is overly strict: it checks that the exported protocols are exactly the same, which | ||
| # cannot handle differening exported protocol versions. |
There was a problem hiding this comment.
nit: s/differening/differing
The PR that fixed this, #24947, didn't add a test. Fixes: #31443 Differential Revision: [D19170020](https://our.internmc.facebook.com/intern/diff/D19170020) [ghstack-poisoned]
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
) Summary: Pull Request resolved: pytorch#31451 The PR that fixed this, pytorch#24947, didn't add a test. Fixes: pytorch#31443 Test Plan: Imported from OSS Differential Revision: D19170020 Pulled By: gchanan fbshipit-source-id: bdbf09989ac8a61b1b70bb1ddee103caa8ef435b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
__cuda_array_interface__inferred strides. #31451 Test reading__cuda_array_interface__inferred strides.The PR that fixed this, #24947, didn't add a test.
Fixes: #31443
Differential Revision: D19170020