Skip to content

Conversation

@z-a-f
Copy link

@z-a-f z-a-f commented Jan 31, 2020

Stack from ghstack:

Differential Revision: D19673463

@z-a-f z-a-f requested a review from apaszke as a code owner January 31, 2020 23:46
z-a-f pushed a commit that referenced this pull request Jan 31, 2020
ghstack-source-id: 57394e6
Pull Request resolved: #32890
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jan 31, 2020
@z-a-f z-a-f requested review from jamesr66a and jerryzh168 January 31, 2020 23:47
@jerryzh168
Copy link
Contributor

Why? could you implement the required method?

@kostmo
Copy link
Member

kostmo commented Feb 1, 2020

💊 CircleCI build failures summary and remediations

As of commit 7dbd48f:

None of the build failures appear to be your fault.

  • 1/3 broken upstream at merge base c917a24 since Feb 10

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.

  • 2/3 recognized as flaky ❄️

    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 2 failures recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build caffe2_onnx_py3_6_clang7_ubuntu16_04_test (1/2)

Step: "Test" (full log | pattern match details) ❄️

Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_transpose_matmul PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_unsqueeze PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_error_on_data_parallel PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_is_in_onnx_export PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_strip_doc_string PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_div PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_mul PASSED [ 99%] 
Feb 10 20:07:20 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault 
Feb 10 20:07:20  
Feb 10 20:07:20 Current thread 0x00007fd9a46a7700 (most recent call first): 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 43 in repr_instance 
Feb 10 20:07:20   File "/usr/lib/python3.6/reprlib.py", line 65 in repr1 
Feb 10 20:07:20   File "/usr/lib/python3.6/reprlib.py", line 55 in repr 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 36 in repr 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 67 in saferepr 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 655 in repr_args 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 736 in repr_traceback_entry 
Feb 10 20:07:20   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 777 in repr_traceback 

See CircleCI build caffe2_onnx_py2_gcc5_ubuntu16_04_test (2/2)

Step: "Test" (full log | pattern match details) ❄️

Feb 10 20:08:06 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape /var/lib/jenkins/workspace/scripts/onnx/test.sh: line 57: 2219 Segmentation fault (core dumped) pytest "${args[@]}" --ignore "$top_dir/test/onnx/test_pytorch_onnx_onnxruntime.py" --ignore "$top_dir/test/onnx/test_custom_ops.py" --ignore "$top_dir/test/onnx/test_models_onnxruntime.py" "${test_paths[@]}"
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_constant_fold_transpose_matmul PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_constant_fold_unsqueeze PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_error_on_data_parallel PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_is_in_onnx_export PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_strip_doc_string PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_div PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Feb 10 20:08:05 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_mul PASSED [ 99%] 
Feb 10 20:08:06 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape /var/lib/jenkins/workspace/scripts/onnx/test.sh: line 57:  2219 Segmentation fault      (core dumped) pytest "${args[@]}" --ignore "$top_dir/test/onnx/test_pytorch_onnx_onnxruntime.py" --ignore "$top_dir/test/onnx/test_custom_ops.py" --ignore "$top_dir/test/onnx/test_models_onnxruntime.py" "${test_paths[@]}" 

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 4 times.

@z-a-f
Copy link
Author

z-a-f commented Feb 1, 2020

Why? could you implement the required method?

Do you mean the .double? If so, I could, it's just this seemed to be easier :)

@z-a-f z-a-f added the oncall: quantization Quantization support in PyTorch label Feb 1, 2020
@jerryzh168
Copy link
Contributor

jerryzh168 commented Feb 3, 2020

I see, I thought we also want to compare the quantized info. Looks like this is just numeric comparison, then this should be fine.

z-a-f pushed a commit that referenced this pull request Feb 10, 2020
ghstack-source-id: c608237
Pull Request resolved: #32890
@facebook-github-bot
Copy link
Contributor

@z-a-f merged this pull request in acd51e1.

@facebook-github-bot facebook-github-bot deleted the gh/zafartahirov/115/head branch February 15, 2020 15:16
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary: Pull Request resolved: pytorch#32890

Test Plan: Imported from OSS

Differential Revision: D19673463

Pulled By: z-a-f

fbshipit-source-id: 453ff662810845fcaeb8e6d5919afa8e2d395768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue oncall: quantization Quantization support in PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants