Skip to content

Enable test_DistributedDataParallel_SyncBatchNorm_2D_Input unit test #33573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable test_DistributedDataParallel_SyncBatchNorm_2D_Input unit test #33573

wants to merge 1 commit into from

Conversation

jithunnair-amd
Copy link
Collaborator

Test needs ability to toggle cuDNN/MIOpen at runtime (enabled in PR #33118)

@albanD
Copy link
Collaborator

albanD commented Feb 21, 2020

This is just for testing CI?
Can you add a [DO NOT MERGE] on the title if so.

@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 21, 2020
@jithunnair-amd
Copy link
Collaborator Author

No, this is actually meant to be merged. However, I see the rocm CI run failed, I'll look into it.

@albanD albanD requested a review from mrshenli February 21, 2020 16:32
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot retest this please

@jithunnair-amd
Copy link
Collaborator Author

Debugging offline, the issue seemed to do with error being slightly out of threshold. Since the assertEqual logic has been revamped, this test is passing locally for the same config that used to fail earlier. @pytorchbot retest this please.

@jithunnair-amd
Copy link
Collaborator Author

CI run 1 passed. Rerunning again to rule out any flakiness. @pytorchbot retest this please

@jithunnair-amd
Copy link
Collaborator Author

CI run 2 passed. Rerunning a third time to rule out any flakiness. @pytorchbot retest this please.

@jithunnair-amd
Copy link
Collaborator Author

CI run 3 passed. @ezyang Ready to merge

facebook-github-bot
facebook-github-bot reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in b4d486a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli Awaiting requested review from mrshenli

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jithunnair-amd @albanD @facebook-github-bot @pytorchbot @mruberry