.circleci: Divert packages to test channel on tag #33842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up PIP_UPLOAD_FOLDER to point to the correct channel for release candidates as opposed to nightlies. Removes an old safety check that's not needed anymore for devtoolset3 And provides a nice default for PIP_UPLOAD_FOLDER, which should clear up confusion on where it's initially set Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
kostmo
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
@seemethere is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@seemethere merged this pull request in 6eef66e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
Summary: Conda registers a suffixed slash as a new user so it was failing to upload the anaconda packages. In the future this should be handled through a single variable that can be used for both but until then this will have to do. Bug was introduced in #33842 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #33903 Differential Revision: D20148679 Pulled By: seemethere fbshipit-source-id: 27c95f5d906ce84aa34bf5d76fd6f1ef5df08fb9
hczhu
pushed a commit
that referenced
this pull request
Feb 28, 2020
Summary: This sets up PIP_UPLOAD_FOLDER to point to the correct channel for release candidates as opposed to nightlies. Removes an old safety check that's not needed anymore for devtoolset3 And provides a nice default for PIP_UPLOAD_FOLDER, which should clear up confusion on where it's initially set This is a stepping stone towards the promotable pipeline. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #33842 Differential Revision: D20130791 Pulled By: seemethere fbshipit-source-id: dac94ef46299574c36c08c968dd36faddeae6363
hczhu
pushed a commit
that referenced
this pull request
Feb 28, 2020
Summary: Conda registers a suffixed slash as a new user so it was failing to upload the anaconda packages. In the future this should be handled through a single variable that can be used for both but until then this will have to do. Bug was introduced in #33842 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #33903 Differential Revision: D20148679 Pulled By: seemethere fbshipit-source-id: 27c95f5d906ce84aa34bf5d76fd6f1ef5df08fb9
1 task
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2020
Summary: ## What this will do: When the repository is tagged the current nightly build pipelines will run and upload to the `test` subdirectory in our S3 bucket for `download.pytorch.org`. Will also upload to the correct organization on anaconda [pytorch-nightly](https://anaconda.org/pytorch-test) This is only meant for release candidates and will actually not run on any tag that does not match the release candidate regex. This has been tested on a small scale with: seemethere/test-repo@3ebe0ff ## Related PRs: * `.circleci: Divert packages to test channel on tag`: #33842 * `.cirlceci: Swap PYTORCH_BUILD_VERSION if on tag`: #33326 ## Work to be done later: - [ ] Figure out how to remove manual step of updating s3 html indices. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #34078 Differential Revision: D20204104 Pulled By: seemethere fbshipit-source-id: 685630e8a04b19fc17374585e9228a13a8c3e407
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: This sets up PIP_UPLOAD_FOLDER to point to the correct channel for release candidates as opposed to nightlies. Removes an old safety check that's not needed anymore for devtoolset3 And provides a nice default for PIP_UPLOAD_FOLDER, which should clear up confusion on where it's initially set This is a stepping stone towards the promotable pipeline. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#33842 Differential Revision: D20130791 Pulled By: seemethere fbshipit-source-id: dac94ef46299574c36c08c968dd36faddeae6363
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Conda registers a suffixed slash as a new user so it was failing to upload the anaconda packages. In the future this should be handled through a single variable that can be used for both but until then this will have to do. Bug was introduced in pytorch#33842 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#33903 Differential Revision: D20148679 Pulled By: seemethere fbshipit-source-id: 27c95f5d906ce84aa34bf5d76fd6f1ef5df08fb9
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: ## What this will do: When the repository is tagged the current nightly build pipelines will run and upload to the `test` subdirectory in our S3 bucket for `download.pytorch.org`. Will also upload to the correct organization on anaconda [pytorch-nightly](https://anaconda.org/pytorch-test) This is only meant for release candidates and will actually not run on any tag that does not match the release candidate regex. This has been tested on a small scale with: seemethere/test-repo@3ebe0ff ## Related PRs: * `.circleci: Divert packages to test channel on tag`: pytorch#33842 * `.cirlceci: Swap PYTORCH_BUILD_VERSION if on tag`: pytorch#33326 ## Work to be done later: - [ ] Figure out how to remove manual step of updating s3 html indices. Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#34078 Differential Revision: D20204104 Pulled By: seemethere fbshipit-source-id: 685630e8a04b19fc17374585e9228a13a8c3e407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up PIP_UPLOAD_FOLDER to point to the correct channel for
release candidates as opposed to nightlies.
Removes an old safety check that's not needed anymore for devtoolset3
And provides a nice default for PIP_UPLOAD_FOLDER, which should clear up
confusion on where it's initially set
This is a stepping stone towards the promotable pipeline.
Signed-off-by: Eli Uriegas eliuriegas@fb.com