profile block outputs; helps guard elimination #33889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
💊 CircleCI build failures summary and remediationsAs of commit 2f976e5 (more details on the Dr. CI page): Commit 2f976e5 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 19 times. |
zdevito
approved these changes
Mar 2, 2020
torch/csrc/jit/profiling_record.cpp
Outdated
There was a problem hiding this comment.
It's easy to tell "what" from the code, can you explain "why"?
Krovatkin
force-pushed
the
krovatkin/profile_block_outputs
branch
from
1bd3c47 to
e0a1978
Compare
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
fix failing tests fix more failing tests add comment fix comment and remove prints
Krovatkin
force-pushed
the
krovatkin/profile_block_outputs
branch
from
e0a1978 to
2f976e5
Compare
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Krovatkin merged this pull request in e16908c. |
bertmaher
pushed a commit
to bertmaher/pytorch
that referenced
this pull request
Mar 13, 2020
Summary: Pull Request resolved: pytorch#33889 Reviewed By: zdevito Differential Revision: D20294979 Pulled By: Krovatkin fbshipit-source-id: 2a68710ec8f8f854c99dfe173f49da442a39e498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.