[pytorch][mobile] change mobile build scripts to build PyTorch by default

[ljk53]

Stack from ghstack:

• [pytorch][mobile] change mobile build scripts to build PyTorch by default #34203 [pytorch][mobile] change mobile build scripts to build PyTorch by default

Summary:
Currently cmake and mobile build scripts still build libcaffe2 by
default. To build pytorch mobile users have to set environment variable
BUILD_PYTORCH_MOBILE=1 or set cmake option BUILD_CAFFE2_MOBILE=OFF.

PyTorch mobile has been released for a while. It's about time to change
CMake and build scripts to build libtorch by default.

Changed caffe2 CI job to build libcaffe2 by setting BUILD_CAFFE2_MOBILE=1
environment variable. Only found android CI for libcaffe2 - do we ever
have iOS CI for libcaffe2?

Differential Revision: D20267274

[ljk53]

Do we still run this CI job? Could find it in .circleci/config.yml

[ezyang]

It's still used, see caffe2_linux_build

[ljk53]

caffe2_linux_build

right, but caffe2_linux_build doesn't seem to have any job with "${BUILD_ENVIRONMENT}" == *-android* (I meant to ask about the caffe2 android CI)

[dr-ci]

💊 CircleCI build failures summary and remediations

As of commit 9ff683b (more details on the Dr. CI page):

---

✅ None of the build failures appear to be your fault 💚

---

• 1/1 tentatively recognized as flaky ❄️
  • Click here to rerun these jobs

---

❄️ 1 tentatively flaky failure

1 failure tentatively classified as flaky but have not launched reruns to confirm:

caffe2_onnx_py2_gcc5_ubuntu16_04_test (1/1)

Step: "Test" (full log | pattern match details) ❄️

Mar 06 02:48:38 E RuntimeError: required keyword attribute 'Y_scale' is undefined

Mar 06 02:48:38 k = 'Y_scale' 
Mar 06 02:48:38  
Mar 06 02:48:38     def _node_getitem(self, k): 
Mar 06 02:48:38         r""" 
Mar 06 02:48:38         Accessor for attributes of a node which is polymorphic over 
Mar 06 02:48:38         return type. 
Mar 06 02:48:38      
Mar 06 02:48:38         NB: This is monkey-patched onto Node. 
Mar 06 02:48:38         """ 
Mar 06 02:48:38 >       sel = self.kindOf(k) 
Mar 06 02:48:38 E       RuntimeError: required keyword attribute 'Y_scale' is undefined 
Mar 06 02:48:38  
Mar 06 02:48:38 ../.local/lib/python2.7/site-packages/torch/onnx/utils.py:869: RuntimeError 
Mar 06 02:48:38 =============================== warnings summary =============================== 
Mar 06 02:48:38 /usr/local/lib/python2.7/dist-packages/scipy/_lib/_numpy_compat.py:10 
Mar 06 02:48:38   /usr/local/lib/python2.7/dist-packages/scipy/_lib/_numpy_compat.py:10: DeprecationWarning: Importing from numpy.testing.nosetester is deprecated since 1.15.0, import from numpy.testing instead. 
Mar 06 02:48:38     from numpy.testing.nosetester import import_nose 
Mar 06 02:48:38  
Mar 06 02:48:38 /usr/local/lib/python2.7/dist-packages/scipy/stats/morestats.py:12 
Mar 06 02:48:38   /usr/local/lib/python2.7/dist-packages/scipy/stats/morestats.py:12: DeprecationWarning: Importing from numpy.testing.decorators is deprecated since numpy 1.15.0, import from numpy.testing instead. 
Mar 06 02:48:38     from numpy.testing.decorators import setastest 

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 19 times.

[ezyang]

Pretty sure it's Android only, but maybe @pietern would know better

[facebook-github-bot]

@ljk53 merged this pull request in 9a5e9d8.