Skip to content

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Mar 9, 2020

This PR is BC-breaking in the following way:

  • The deprecated torch::nn::BatchNorm is removed in favor of torch::nn::BatchNorm{1,2,3}d
  • The deprecated torch::nn::FeatureDropout is removed in favor of torch::nn::Dropout{2,3}d
  • The deprecated torch::nn::modules_ordered_dict is removed. User should do Sequential sequential({{"m1", MyModule(1)}, {"m2", MyModule(2)}}) instead.
  • The deprecated torch::nn::init::Nonlinearity is removed, in favor of the following enums:
    • torch::kLinear
    • torch::kConv1D
    • torch::kConv2D
    • torch::kConv3D
    • torch::kConvTranspose1D
    • torch::kConvTranspose2D
    • torch::kConvTranspose3D
    • torch::kSigmoid
    • torch::kTanh
    • torch::kReLU
    • torch::kLeakyReLU
  • The deprecated torch::nn::init::FanMode is removed, in favor of the following enums:
    • torch::kFanIn
    • torch::kFanOut

@yf225 yf225 added the module: cpp Related to C++ API label Mar 9, 2020
@yf225 yf225 requested a review from pbelevich March 9, 2020 22:24
@yf225 yf225 removed request for ebetica and goldsborough March 9, 2020 22:27
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Mar 9, 2020

💊 CircleCI build failures summary and remediations

As of commit 718cbf4 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 2/2 broken upstream at merge base d30fa48 since Mar 09

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.


🚧 2 upstream failures:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 24 times.

@yf225 yf225 changed the title [C++ API] Remove deprecated torch::nn::BatchNorm and torch::nn::init::Nonlinearity / FanMode [C++ API] Remove deprecated torch::nn::BatchNorm / FeatureDropout and torch::nn::init::Nonlinearity / FanMode Mar 9, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 changed the title [C++ API] Remove deprecated torch::nn::BatchNorm / FeatureDropout and torch::nn::init::Nonlinearity / FanMode [C++ API] Remove deprecated torch::nn::BatchNorm / FeatureDropout / modules_ordered_dict and torch::nn::init::Nonlinearity / FanMode Mar 9, 2020
@yf225 yf225 added the module: bc-breaking Related to a BC-breaking change label Mar 9, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in a54416d.

@facebook-github-bot facebook-github-bot deleted the cpp_remove_deprecated branch July 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: bc-breaking Related to a BC-breaking change module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants