Skip to content

Conversation

@kmatzen
Copy link
Contributor

@kmatzen kmatzen commented Mar 11, 2020

Summary: These templated function calls are not specifying the template args correctly. The first arg is the index type, not the array data type. That means, right now it's using T as the index type as well, which will break if we do a template specialization for uint8_t. If we omit both, it will correctly infer that the index type is int and the data type is T.

Reviewed By: BIT-silence

Differential Revision: D20358728

Summary: These templated function calls are not specifying the template args correctly.  The first arg is the index type, not the array data type.  That means, right now it's using `T` as the index type as well, which will break if we do a template specialization for uint8_t.  If we omit both, it will correctly infer that the index type is `int` and the data type is `T`.

Reviewed By: BIT-silence

Differential Revision: D20358728

fbshipit-source-id: 4f5d2c8960dc67b5878bcdc7b521157abaa1d0aa
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20358728

@dr-ci
Copy link

dr-ci bot commented Mar 12, 2020

💊 CircleCI build failures summary and remediations

As of commit 13ab584 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details)

Mar 11 16:05:07 FAIL [306.462s]: test_barrier_timeout_group (__main__.TestDistBackend)
Mar 11 15:59:41     self._target(*self._args, **self._kwargs) 
Mar 11 15:59:41   File "distributed/test_distributed.py", line 2127, in _run 
Mar 11 15:59:41     self._barrier() 
Mar 11 15:59:41   File "distributed/test_distributed.py", line 280, in _barrier 
Mar 11 15:59:41     Barrier.sync(*args, **kwargs) 
Mar 11 15:59:41   File "distributed/test_distributed.py", line 274, in sync 
Mar 11 15:59:41     raise RuntimeError("barrier timeout") 
Mar 11 15:59:41 RuntimeError: barrier timeout 
Mar 11 16:05:07 F.s..s......................s..s........s 
Mar 11 16:05:07 ====================================================================== 
Mar 11 16:05:07 FAIL [306.462s]: test_barrier_timeout_group (__main__.TestDistBackend) 
Mar 11 16:05:07 ---------------------------------------------------------------------- 
Mar 11 16:05:07 Traceback (most recent call last): 
Mar 11 16:05:07   File "distributed/test_distributed.py", line 2050, in wrapper 
Mar 11 16:05:07     self._join_and_reduce(fn) 
Mar 11 16:05:07   File "distributed/test_distributed.py", line 2143, in _join_and_reduce 
Mar 11 16:05:07     "Timeout waiting for rank %d to terminate" % rank) 
Mar 11 16:05:07 AssertionError: True is not false : Timeout waiting for rank 1 to terminate 
Mar 11 16:05:07  
Mar 11 16:05:07 ---------------------------------------------------------------------- 
Mar 11 16:05:07 Ran 94 tests in 366.583s 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 17 times.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6d8649d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants