[caffe2] fix Transpose2D calls in NHWC<->NCHW #34625
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These templated function calls are not specifying the template args correctly. The first arg is the index type, not the array data type. That means, right now it's using
Tas the index type as well, which will break if we do a template specialization for uint8_t. If we omit both, it will correctly infer that the index type isintand the data type isT.Reviewed By: BIT-silence
Differential Revision: D20358728