Turn on exact_dtype by default on test_optim.py

[great-way]

Stack from ghstack:

• Turn on exact_dtype by default on test_optim.py #34825 Turn on exact_dtype by default on test_optim.py

Differential Revision: D20498111

[ezyang]

Don't do this; exact_dtype is intended to be a class global property. Just set exact_dtype = True directly in the class, like in the other PR.

[great-way]

I'm not sure my understanding is correct. Doing self.exact_dtype = True in a class member function should be equivalent to directly set exact_dtype = True in the class? Also when we modify the inherited attribute exact_dtype, I guess it won't affect the attribute value of the parent's other subclasses, since they instantiate a different class object.

[ezyang]

No it is not equivalent (although in this particular case I can believe that they are functionally equivalent)

ezyang-mbp:Dev ezyang$ python arf.py
True
Traceback (most recent call last):
  File "arf.py", line 9, in <module>
    print(A2.b)
AttributeError: class A2 has no attribute 'b'
ezyang-mbp:Dev ezyang$ cat arf.py
class A:
    b = True

class A2:
    def __init__(self):
        self.b = True

print(A.b)
print(A2.b)

[ezyang]

looks promising!

[dr-ci]

💊 CircleCI build failures summary and remediations

As of commit 85fee57 (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 17 times.

[facebook-github-bot]

@great-way merged this pull request in 5857a12.