-
Notifications
You must be signed in to change notification settings - Fork 25.6k
.circleci: Ensure describe happens in pytorch repo #35065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 9603e73 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 10 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemethere is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
33ab3ca
to
a9edfd5
Compare
Found an issue where the git describe wasn't properly executed since the binary_populate_env.sh script was being executed from a different directory. 'git -C' forces the describe to run in the running directory for the script which should contain the correct git information Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Older versions of git do not contain the '-C' flag so let's switch to a flag that is pre-historic and will run on any version of RHEL that is still supported in the modern era. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
--git-dir only works when it points directly to a .git folder Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
git doesn't handle the escapes correctly so let's just not put them altogether. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Discovered that the upload scripts do not do well when there's no pytorch repository to actually do git operations on. CirlceCI however provides a nice environment variable with the name of the current tag so let's just use that when it's available and fall back on the git describe functionality if that fails. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
a9edfd5
to
d572149
Compare
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
d572149
to
9603e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@seemethere merged this pull request in b2dcedf. |
Found an issue where the git describe wasn't properly executed since the
binary_populate_env.sh script was being executed from a different
directory.
'git -C' forces the describe to run in the running directory for the
script which should contain the correct git information
Signed-off-by: Eli Uriegas eliuriegas@fb.com