[caffe2] merge internal (RowWise)SparseAdagrad into open source version #35090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D20552770 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D20552770 |
jspark1105
force-pushed
the
export-D20552770
branch
from
cb40b42 to
c21475f
Compare
💊 CircleCI build failures summary and remediationsAs of commit 9e05082 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 times. |
jspark1105
force-pushed
the
export-D20552770
branch
from
c21475f to
51d8cf0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20552770 |
…on (pytorch#35090) Summary: Pull Request resolved: pytorch#35090 As a preparation to open source fp16 + stochastic rounding SparseAdagrad and fused SparseAdagrad Other minor changes: * Removed template parameters T that are not actually used * Removed unnecessary anonymous namespaces used in header files Differential Revision: D20552770 fbshipit-source-id: 6e2cdf3db4586861a86cdbff4af179541ae53048
|
This pull request was exported from Phabricator. Differential Revision: D20552770 |
jspark1105
force-pushed
the
export-D20552770
branch
from
51d8cf0 to
9e05082
Compare
|
This pull request has been merged in 8346959. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As a preparation to open source fp16 + stochastic rounding SparseAdagrad and fused SparseAdagrad
Differential Revision: D20552770