Skip to content

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Mar 25, 2020

Stack from ghstack:

This would make intdiv_256 a much more generic template that can easily accommodate other types of binary operators in the future. The operator becomes "out-of-place" because this would make it easier to substitute with other operators, and compilers should have no problem optimizing this.

Differential Revision: D20826861

@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit 1db1672 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 2 times.

@ngimel
Copy link
Collaborator

ngimel commented Mar 25, 2020

Can you please comment on why are you making this change and why are you replacing an in-place version of the operation with the out-of-place?

@xuhdev
Copy link
Collaborator Author

xuhdev commented Mar 25, 2020

Can you please comment on why are you making this change and why are you replacing an in-place version of the operation with the out-of-place?

Please see my update. I was doing this because I planned to add similar code for bit shifting operators, but it turned out to be unnecessary at this moment. Nevertheless, I decided to keep this part of the changes because it can be helpful for future incorporation of other binary operators.

@xuhdev
Copy link
Collaborator Author

xuhdev commented Apr 2, 2020

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Apr 2, 2020
facebook-github-bot pushed a commit that referenced this pull request Apr 3, 2020
Summary:
Pull Request resolved: #35422

This would make `intdiv_256` a much more generic template that can easily accommodate other types of binary operators in the future. The operator becomes "out-of-place" because this would make it easier to substitute with other operators, and compilers should have no problem optimizing this.

Test Plan: Imported from OSS

Differential Revision: D20826861

Pulled By: ngimel

fbshipit-source-id: a6d0706cc1a585063426e988d9982bad402a9b36
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in beac3f2.

@facebook-github-bot facebook-github-bot deleted the gh/xuhdev/68/head branch April 7, 2020 14:17
@xuhdev xuhdev restored the gh/xuhdev/68/head branch April 14, 2020 00:34
@xuhdev
Copy link
Collaborator Author

xuhdev commented Apr 14, 2020

This is actually merged in ea8021d

@xuhdev xuhdev deleted the gh/xuhdev/68/head branch April 14, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please Merged open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants