-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Make intdiv_256 a more generic binary operator template #35422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit 1db1672 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
|
Can you please comment on why are you making this change and why are you replacing an in-place version of the operation with the out-of-place? |
Please see my update. I was doing this because I planned to add similar code for bit shifting operators, but it turned out to be unnecessary at this moment. Nevertheless, I decided to keep this part of the changes because it can be helpful for future incorporation of other binary operators. |
|
@pytorchbot merge this please |
Summary: Pull Request resolved: #35422 This would make `intdiv_256` a much more generic template that can easily accommodate other types of binary operators in the future. The operator becomes "out-of-place" because this would make it easier to substitute with other operators, and compilers should have no problem optimizing this. Test Plan: Imported from OSS Differential Revision: D20826861 Pulled By: ngimel fbshipit-source-id: a6d0706cc1a585063426e988d9982bad402a9b36
|
This is actually merged in ea8021d |
Stack from ghstack:
This would make
intdiv_256a much more generic template that can easily accommodate other types of binary operators in the future. The operator becomes "out-of-place" because this would make it easier to substitute with other operators, and compilers should have no problem optimizing this.Differential Revision: D20826861