[clang-format] Replace asyncio.run with approximation supported in python 3.6 #35501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplitInfinity
changed the title
…thon 3.6 Summary: `asyncio.run` is supported only after 3.7 and that too, provisionally so. This commit replaces the use of `asyncio.run` in `tools/clang_format.py` with an approximation that works in both 3.6 and 3.7. Testing: Ran the script with both `python3.6` and `python3.7`.
SplitInfinity
force-pushed
the
clang-format-py3.6
branch
from
8e6d668 to
e3fee85
Compare
💊 CircleCI build failures summary and remediationsAs of commit e3fee85 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
There was a problem hiding this comment.
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@SplitInfinity merged this pull request in b0459fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.runis supported only after 3.7 and that too, provisionally so.This commit replaces the use of
asyncio.runintools/clang_format.pywith an approximation that works in both 3.6 and 3.7.
Testing
Ran the script with both
python3.6andpython3.7.