Skip to content

Conversation

dreiss
Copy link
Contributor

@dreiss dreiss commented Mar 28, 2020

Stack from ghstack:

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
func.__wrapped__ can be used directly in Python 3.

Test Plan:
CI

Differential Revision: D20842875

Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI
@dr-ci
Copy link

dr-ci bot commented Mar 28, 2020

💊 CI failures summary and remediations

As of commit 5a26ac7 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build caffe2_onnx_ort1_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

May 14 04:19:02 E AssertionError: False is not true
May 14 04:19:02         worker_coordinator = parallel_workers.init_workers(dummy_worker) 
May 14 04:19:02         worker_coordinator.start() 
May 14 04:19:02      
May 14 04:19:02         for _ in range(10): 
May 14 04:19:02             value = dequeue_value(queue) 
May 14 04:19:02             self.assertTrue( 
May 14 04:19:02                 value in [b'0', b'1'], 'Got unexpected value ' + str(value) 
May 14 04:19:02             ) 
May 14 04:19:02      
May 14 04:19:02 >       self.assertTrue(worker_coordinator.stop()) 
May 14 04:19:02 E       AssertionError: False is not true 
May 14 04:19:02  
May 14 04:19:02 ../.local/lib/python3.6/site-packages/caffe2/python/parallel_workers_test.py:73: AssertionError 
May 14 04:19:02 ----------------------------- Captured stdout call ----------------------------- 
May 14 04:19:02 Wait for workers to die: train 
May 14 04:19:02 Worker <Thread(parallel_workers worker id 1, started daemon 140289956091648)> failed to close while waiting 
May 14 04:19:02 All workers terminated: False 
May 14 04:19:02 - generated xml file: /var/lib/jenkins/workspace/caffe2_tests/python/result.xml - 
May 14 04:19:02 ---------- onnx coverage: ---------- 
May 14 04:19:02 Operators (passed/loaded/total): 0/0/185 
May 14 04:19:02 ------------------------------------ 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 47 times.

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp for changes in test_c10d.py

dreiss added 6 commits April 3, 2020 09:08
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)

[ghstack-poisoned]
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)

[ghstack-poisoned]
okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

ghstack-source-id: 4751f22
Pull Request resolved: pytorch/pytorch#35621
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)
Summary:
Python 2 has reached end-of-life and is no longer supported by PyTorch.
`func.__wrapped__` can be used directly in Python 3.

Test Plan:
CI

Differential Revision: [D20842875](https://our.internmc.facebook.com/intern/diff/D20842875)
@facebook-github-bot
Copy link
Contributor

@dreiss merged this pull request in 313bea8.

@facebook-github-bot facebook-github-bot deleted the gh/dreiss/38/head branch May 18, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants