Skip to content

Conversation

jianyuh
Copy link
Member

@jianyuh jianyuh commented Mar 31, 2020

Stack from ghstack:

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient

  • SparseAdagradFusedWithSparseLengthsSumGradient
  • RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
  • SparseAdagradFusedWithSparseLengthsWeightedSumGradient
  • RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: D20453096

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

This will benefit for TSTAR (Zion) and TS (Training Supercomputer) project.

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Mar 31, 2020
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

This will benefit for TSTAR (Zion) and TS (Training Supercomputer) project.

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

ghstack-source-id: 101206036
Pull Request resolved: #35762
@dr-ci
Copy link

dr-ci bot commented Mar 31, 2020

💊 Build failures summary and remediations

As of commit 2018864 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 33 times.

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Apr 4, 2020
Pull Request resolved: #35762

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!
ghstack-source-id: 101536379
@jianyuh jianyuh mentioned this pull request Apr 4, 2020
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Apr 4, 2020
Pull Request resolved: #35762

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!
ghstack-source-id: 101544700
@jianyuh jianyuh changed the title [WIP] CUDA implementation of Sparse Adagrad Fusion for GPUs CUDA implementation of Sparse Adagrad Fusion for GPUs Apr 4, 2020
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Apr 6, 2020
Pull Request resolved: #35762

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!
ghstack-source-id: 101569272
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Apr 7, 2020
Pull Request resolved: #35762

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!
ghstack-source-id: 101708597
We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!

[ghstack-poisoned]
jianyuh added a commit that referenced this pull request Apr 21, 2020
Pull Request resolved: #35762

We implement the following operators for Regular and RowWise SparseAdagrad Fusion with SLS and SLWS gradient
- SparseAdagradFusedWithSparseLengthsSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsSumGradient
- SparseAdagradFusedWithSparseLengthsWeightedSumGradient
- RowWiseSparseAdagradFusedWithSparseLengthsWeightedSumGradient

Differential Revision: [D20453096](https://our.internmc.facebook.com/intern/diff/D20453096/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D20453096/)!
ghstack-source-id: 102583129
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 171476e.

@facebook-github-bot facebook-github-bot deleted the gh/jianyuh/63/head branch April 26, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants