Adds NumPy array x Torch tensor binary ufunc interaction test #35945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruberry
added
the
module: numpy
💊 Build failures summary and remediationsAs of commit fe2f015 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 16 times. |
xuhdev
reviewed
Apr 3, 2020
xuhdev
reviewed
Apr 3, 2020
added 2 commits
April 5, 2020 22:39
This was referenced Apr 6, 2020
mruberry
commented
Apr 7, 2020
mruberry
commented
Apr 7, 2020
mruberry
commented
Apr 7, 2020
mruberry
commented
Apr 7, 2020
mruberry
commented
Apr 7, 2020
mruberry
commented
Apr 7, 2020
xuhdev
reviewed
Apr 7, 2020
added 3 commits
April 9, 2020 04:29
mruberry
changed the title
gchanan
reviewed
Apr 10, 2020
gchanan
reviewed
Apr 10, 2020
gchanan
approved these changes
Apr 10, 2020
added 3 commits
April 10, 2020 21:41
added 2 commits
April 10, 2020 22:20
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
…h#35945) Summary: Adds test for behavior reported in pytorch#35257 to ensure it doesn't regress. The test was extended to reveal three additional issues: - pytorch#36363 - pytorch#36058 - pytorch#36057 Pull Request resolved: pytorch#35945 Differential Revision: D20984429 Pulled By: mruberry fbshipit-source-id: a15be9455afba9c77e40c337a860f9be348bf8d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for behavior reported in #35257 to ensure it doesn't regress. The test was extended to reveal three additional issues: