[TensorExpr] scalar factorization of Div #36154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
💊 CircleCI build failures summary and remediationsAs of commit 49ce742 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 times. |
There was a problem hiding this comment.
@nickgg is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
nickgg
force-pushed
the
divSimplification
branch
from
9d70f22 to
49ce742
Compare
There was a problem hiding this comment.
@nickgg is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
Summary: Add support for the TensorExpr IR Simplifier to factorize common terms on either side of a Div node. e.g. `(8 * x) / (4 * y) => (2 * x) / y`. Pull Request resolved: pytorch#36154 Differential Revision: D20910580 Pulled By: nickgg fbshipit-source-id: ee071d93bc4711b1e710be312de599d18ab506f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the TensorExpr IR Simplifier to factorize common terms on either side of a Div node. e.g.
(8 * x) / (4 * y) => (2 * x) / y.