-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[JIT] fix alias assertion #36178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] fix alias assertion #36178
Conversation
💊 CircleCI build failures summary and remediationsAs of commit a9073f0 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, but it may be possible to make the code paths' intent clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: AnyType wasn't listed as a mutable type, so the assertion triggered (yay!). Also update the `isMutableTypeInternal(from) != isMutableTypeInternal` logic to be more encompassing. Pull Request resolved: pytorch#36178 Differential Revision: D20922356 Pulled By: eellison fbshipit-source-id: 7060a62b18e98dc24b6004a66225c196aadb566e
AnyType wasn't listed as a mutable type, so the assertion triggered (yay!). Also update the
isMutableTypeInternal(from) != isMutableTypeInternal
logic to be more encompassing.