Skip to content

Conversation

zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Apr 9, 2020

Stack from ghstack:

Differential Revision: D20943003

@zasdfgbnm zasdfgbnm requested review from albanD and apaszke as code owners April 9, 2020 09:02
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 9, 2020
@zasdfgbnm zasdfgbnm requested a review from ezyang April 9, 2020 09:03
zasdfgbnm added a commit that referenced this pull request Apr 9, 2020
ghstack-source-id: d645e88
Pull Request resolved: #36303
@dr-ci
Copy link

dr-ci bot commented Apr 9, 2020

💊 Build failures summary and remediations

As of commit a8408ac (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 25 times.

@ezyang
Copy link
Contributor

ezyang commented Apr 9, 2020

NB there's a decent chance that code merged in the meantime will conflict with this, you'll have to fix things up if that happens.

@zasdfgbnm
Copy link
Collaborator Author

@ezyang Sure, the command to quickly fix most files is:

find torch -type f -exec sed -i 's/#include "\(.*\)"/#include <\1>/g' {} \;

Some files needs manual intervention

zasdfgbnm added a commit that referenced this pull request Apr 10, 2020
ghstack-source-id: 0a903a4
Pull Request resolved: #36303
@ezyang
Copy link
Contributor

ezyang commented Apr 13, 2020

RIP, this gonna need some internal build system changes.

xplat/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/requantization/gemmlowp-scalar.c:16:10: fatal error: 'ATen/native/quantized/cpu/qnnpack/src/requantization/gemmlowp-scalar.h' file not found
#include <ATen/native/quantized/cpu/qnnpack/src/requantization/gemmlowp-scalar.h>

@ezyang
Copy link
Contributor

ezyang commented Apr 13, 2020

oops, wrong PR, it's the one before this one

zasdfgbnm added a commit that referenced this pull request Apr 17, 2020
ghstack-source-id: 0f5d2cd
Pull Request resolved: #36303
zasdfgbnm added a commit that referenced this pull request Apr 21, 2020
ghstack-source-id: c31dec3
Pull Request resolved: #36303
@zasdfgbnm
Copy link
Collaborator Author

@ezyang This is also ready

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 3880f14.

@zasdfgbnm zasdfgbnm deleted the gh/zasdfgbnm/38/head branch April 23, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants