-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Canonicalize includes in torch, and add tests for it #36303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit a8408ac (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 25 times. |
NB there's a decent chance that code merged in the meantime will conflict with this, you'll have to fix things up if that happens. |
@ezyang Sure, the command to quickly fix most files is: find torch -type f -exec sed -i 's/#include "\(.*\)"/#include <\1>/g' {} \; Some files needs manual intervention |
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
RIP, this gonna need some internal build system changes.
|
oops, wrong PR, it's the one before this one |
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
Differential Revision: [D20943003](https://our.internmc.facebook.com/intern/diff/D20943003) [ghstack-poisoned]
@ezyang This is also ready |
Stack from ghstack:
Differential Revision: D20943003