[jit] Add return statement back to Future::addCallback() #36662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a mistake from an earlier change, though the expected impact is relatively minimal - mostly keeping callback around longer than necessary in the case of callbacks already-completed futures. Differential Revision: [D21044145](https://our.internmc.facebook.com/intern/diff/D21044145/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
Apr 15, 2020
This was a mistake from an earlier change, though the expected impact is relatively minimal - mostly keeping callback around longer than necessary in the case of callbacks already-completed futures. Differential Revision: [D21044145](https://our.internmc.facebook.com/intern/diff/D21044145/) ghstack-source-id: 102203224 Pull Request resolved: #36662
xush6528
approved these changes
Apr 15, 2020
|
This pull request has been merged in a3314f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This was a mistake from an earlier change, though the expected impact is
relatively minimal - mostly keeping callback around longer than necessary
in the case of callbacks already-completed futures.
Differential Revision: D21044145