[torch] Excluding test_fft_input_modification without MKL #36680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D21051362 |
💊 Build failures summary and remediationsAs of commit 3a0a3c8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 19 times. |
malfet
approved these changes
Apr 17, 2020
malfet
reviewed
Apr 17, 2020
test/test_torch.py
Outdated
There was a problem hiding this comment.
Suggested change
| @unittest.skipIf(not TEST_MKL, "PyTorch is built without MKL support") | |
| @skipCPUIfNoMkl() |
letterx
force-pushed
the
export-D21051362
branch
from
ccc16c3 to
042d139
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21051362 |
|
This pull request was exported from Phabricator. Differential Revision: D21051362 |
letterx
force-pushed
the
export-D21051362
branch
from
042d139 to
aea8e04
Compare
) Summary: Pull Request resolved: pytorch#36680 If torch compiled without MKL, this test fails with torch.fft requiring MKL support Test Plan: CI Reviewed By: malfet Differential Revision: D21051362 fbshipit-source-id: eda21814befcbbda5fa34cae59e1b6e771f952c2
|
This pull request was exported from Phabricator. Differential Revision: D21051362 |
letterx
force-pushed
the
export-D21051362
branch
from
aea8e04 to
3a0a3c8
Compare
|
This pull request has been merged in b889e0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If torch compiled without MKL, this test fails with torch.fft requiring MKL support
Test Plan: CI
Differential Revision: D21051362