In interpolate, use if instead of elif

[dreiss]

Stack from ghstack:

• Update interpolate to use new upsample overloads #37177 Update interpolate to use new upsample overloads
• Add interpolate-style overloads to aten::upsample* ops #37176 Add interpolate-style overloads to aten::upsample* ops
• Add support for float[]? arguments in native_functions.yaml #37175 Add support for float[]? arguments in native_functions.yaml
• Add support for int[]? arguments in native_functions.yaml #37174 Add support for int[]? arguments in native_functions.yaml
• In interpolate, inline the call to _interp_output_size #37173 In interpolate, inline the call to _interp_output_size
• In interpolate, move exceptional cases to the bottom #37172 In interpolate, move exceptional cases to the bottom
• In interpolate, use if instead of elif #37171 In interpolate, use if instead of elif

Every one of these branches returns or raises, so there's no need for elif.
This makes it a little easier to reorder and move conditions.

Differential Revision: D21209992

Differential Revision: D21209992

[dr-ci]

💊 CI failures summary and remediations

As of commit 261ef6d (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

[eellison]

this is a reminder for me to do something that has been on my list but hasn't been pressing yet for any particular reason.
If you have a function like:

@torch.jit.script
def test_foo(x: bool, y: bool):
    if x:
        return 1
    return 2
print(test_foo.code)

generates:

def test_foo(x: bool,
    y: bool) -> int:
  _0 = uninitialized(int)
  if x:
    _1, _2 = True, 1
  else:
    _1, _2 = False, _0
  if _1:
    _3 = _2
  else:
    _3 = 2
  return _3

while

@torch.jit.script
def test_foo(x: bool, y: bool):
    if x:
        return 1
    else:
        return 2
print(test_foo.code)

generates:

def test_foo(x: bool,
    y: bool) -> int:
  if x:
    _0 = 1
  else:
    _0 = 2
  return _0

The reason for this is how we destructure early returns into if statements. I can get around to adding a rewrite pass sometime next week, but before then we probably shouldn't add all of these extra if statements in a core function for a non-semantic change.

[facebook-github-bot]

This pull request has been merged in 8f0e254.