[jit] normalize getMethod
#37472
Closed
[jit] normalize getMethod
#37472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. [ghstack-poisoned]
This was referenced Apr 29, 2020
facebook-github-bot
added
the
oncall: jit
💊 Build failures summary and remediationsAs of commit d88da14 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 11 times. |
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. [ghstack-poisoned]
jamesr66a
approved these changes
Apr 30, 2020
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. Differential Revision: [D21297543](https://our.internmc.facebook.com/intern/diff/D21297543) [ghstack-poisoned]
|
I think you're going to have to rebase this past #37424, which is landing now. |
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. Differential Revision: [D21297543](https://our.internmc.facebook.com/intern/diff/D21297543) [ghstack-poisoned]
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. Differential Revision: [D21297543](https://our.internmc.facebook.com/intern/diff/D21297543) [ghstack-poisoned]
Our convention is for `findX` to return an optional version and `getX` to assert that the X is there. Fix up `getMethod` to be consistent with this convention. Differential Revision: [D21297543](https://our.internmc.facebook.com/intern/diff/D21297543) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
getMethod#37472 [jit] normalizegetMethodOur convention is for
findXto return an optional version andgetXto assert that the X is there. Fix up
getMethodto be consistent withthis convention.
Differential Revision: D21297543