graph mode: round out relu support #37592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
jerryzh168
reviewed
May 1, 2020
| x = F.elu(x) | ||
| x = self.hardsigmoid(x) | ||
| x = F.hardsigmoid(x) | ||
| x = self.relu(x) |
There was a problem hiding this comment.
btw, please add inplace versions as well
Summary: Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21366597](https://our.internmc.facebook.com/intern/diff/D21366597) [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 3194893 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
Summary: Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21366597](https://our.internmc.facebook.com/intern/diff/D21366597) [ghstack-poisoned]
bharatr21
pushed a commit
to bharatr21/pytorch
that referenced
this pull request
May 5, 2020
Summary: Pull Request resolved: pytorch#37592 Makes sure that all the standalone relu flavors are tested in graph mode. Test Plan: ``` python test/test_quantization.py TestQuantizeScriptPTSQOps.test_swap_dequantize ``` Imported from OSS Differential Revision: D21366597 fbshipit-source-id: 103848b76a0c65b9adac5bae98b545aa1d30a9e2
|
This pull request has been merged in b354700. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Makes sure that all the standalone relu flavors are tested in
graph mode.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21366597