Change StorageImpl to track byte count rather than element count (#37028)

[ezyang]

Summary:

• Remove type-specific size tracking in favor of byte size tracking in Storage and StorageImpl
• Changed numel() and set_numel() to nbytes() and set_nbytes()
• Added enum argument to Storage/StorageImpl constructor to indicate new meaning of the size parameter
• Update all callers of the changed API

Part of issue #33950
Pull Request resolved: #37028

Differential Revision: D21171334

Pulled By: ezyang

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D21171334

[dr-ci]

💊 Build failures summary and remediations

As of commit 5ad6897 (more details on the Dr. CI page):

---

• 3/3 failures possibly* introduced in this PR
  • 2/3 non-CircleCI failure(s)

---

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details | 🔁 rerun) <confirmed not flaky by 2 failures>

May 04 13:57:23 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41

May 04 13:57:19   test_debug_info (__main__.DistAutogradTestWithSpawn) ... skip (0.005s) 
May 04 13:57:21   test_dist_autograd_profiling (__main__.DistAutogradTestWithSpawn) ... ok (1.258s) 
May 04 13:57:22   test_embedding_bag_with_no_grad_tensors (__main__.DistAutogradTestWithSpawn) ... [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
May 04 13:57:22 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
May 04 13:57:22 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
May 04 13:57:22 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
May 04 13:57:22 ok (1.405s) 
May 04 13:57:23   test_error_in_context (__main__.DistAutogradTestWithSpawn) ... [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
May 04 13:57:23 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
May 04 13:57:23 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
May 04 13:57:23 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
May 04 13:57:23 ok (1.160s) 
May 04 13:57:24   test_grad_copy_sparse_indices_extra_ref (__main__.DistAutogradTestWithSpawn) ... /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1890: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
May 04 13:57:24   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
May 04 13:57:24 /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1890: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
May 04 13:57:24   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
May 04 13:57:24 /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1890: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
May 04 13:57:24   warnings.warn("Argument order/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1890: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
May 04 13:57:24   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
May 04 13:57:24  of nn.functional.embedding_bag was changed. " 
May 04 13:57:24 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 

---

Extra GitHub checks: 1 failed

• Failed: GitHub Actions - clang-tidy

---

ci.pytorch.org: 1 failed

• Failed: pr/py3.6-clang7-rocmdeb-ubuntu16.04

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 3 times.

[facebook-github-bot]

@ezyang merged this pull request in 3706803.