Use torch.ne instead of torch.nonzero in gradcheck #37857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

anjali411 wants to merge 8 commits into gh/anjali411/12/base from gh/anjali411/12/head

Contributor

anjali411 commented May 5, 2020 •

edited

Loading

Stack from ghstack:

Added more tests and a separate list for tests for complex dtype only #38320 More tests
Use torch.ne instead of torch.nonzero in gradcheck #37857 Add testing for more ops and use torch.ne instead of torch.nonzero in gradcheck
Added more autograd tests for C->C complex functions #37856 Added more autograd tests for C->C complex functions

Differential Revision: D21528484


          Add testing for more ops and use torch.eq instead of torch.nonzero in…

bb6c1c0

… gradcheck

[ghstack-poisoned]

anjali411 requested review from albanD and apaszke as code owners

May 5, 2020 19:21

This was referenced May 5, 2020

updated create input and add test methods and added a whitelist for complex #37835

Closed

Fixed gradcheck for complex #37836

Closed

Added more autograd tests for C->C complex functions #37856

Closed

dr-ci bot commented May 5, 2020 •

edited

Loading

💊 CI failures summary and remediations

As of commit e35dcd4 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/py3.6-clang7-rocmdeb-ubuntu16.04

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 52 times.


          Update on "Add testing for more ops and use torch.eq instead of torch…

807c39a

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request


          Add testing for more ops and use torch.eq instead of torch.nonzero in…

2f1f2ee

… gradcheck

ghstack-source-id: 3588355
Pull Request resolved: #37857


          Update on "Add testing for more ops and use torch.eq instead of torch…

64c2617

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request


          Add tests for more ops and use torch.eq instead of torch.nonzero in g…

6bf702d

…radcheck

ghstack-source-id: bdba2b2
Pull Request resolved: #37857


          Update on "Add testing for more ops and use torch.eq instead of torch…

5f08b19

….nonzero in gradcheck"

[ghstack-poisoned]


          Update on "Add testing for more ops and use torch.eq instead of torch…

c73758c

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request


          Add tests for more ops and use torch.eq instead of torch.nonzero in g…

8c92a81

…radcheck

ghstack-source-id: 5cbd2b3
Pull Request resolved: #37857


          Update on "Add testing for more ops and use torch.eq instead of torch…

a30a87d

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request


          Add tests for more ops and use torch.eq instead of torch.nonzero in g…

f3a04fe

…radcheck

ghstack-source-id: 056491a
Pull Request resolved: #37857


          Update on "Add testing for more ops and use torch.eq instead of torch…

6f06282

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request


          Add tests for more ops and use torch.eq instead of torch.nonzero in g…

5a85f1f

…radcheck

ghstack-source-id: e40b261
Pull Request resolved: #37857

anjali411 changed the title ~~Add testing for more ops and use torch.eq instead of torch.nonzero in gradcheck~~ Add testing for more ops and use torch.ne instead of torch.nonzero in gradcheck


          Update on "Add testing for more ops and use torch.ne instead of torch…

e35dcd4

….nonzero in gradcheck"

[ghstack-poisoned]

anjali411 mentioned this pull request

Added more tests and a separate list for tests for complex dtype only #38320

Closed

anjali411 changed the title ~~Add testing for more ops and use torch.ne instead of torch.nonzero in gradcheck~~ Use torch.ne instead of torch.nonzero in gradcheck

albanD approved these changes

View reviewed changes

facebook-github-bot closed this in

d5a7d79

facebook-github-bot added the merged label

Contributor

facebook-github-bot commented May 13, 2020

@anjali411 merged this pull request in d5a7d79.

facebook-github-bot deleted the gh/anjali411/12/head branch

May 16, 2020 14:16

mruberry added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels