Remove unnecessary to_string in RPC logging code. #38414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::to_string` call is unnecessary when using glog. Differential Revision: [D21266330](https://our.internmc.facebook.com/intern/diff/D21266330/) [ghstack-poisoned]
osalpekar
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
osalpekar
added a commit
that referenced
this pull request
May 13, 2020
`std::to_string` call is unnecessary when using glog. Differential Revision: [D21266330](https://our.internmc.facebook.com/intern/diff/D21266330/) ghstack-source-id: 104030161 Pull Request resolved: #38414
💊 CI failures summary and remediationsAs of commit 503211b (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. |
mrshenli
approved these changes
May 14, 2020
|
This pull request has been merged in af59733. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
std::to_stringcall is unnecessary when using glog.Differential Revision: D21266330