Skip to content

Conversation

yinghai
Copy link
Contributor

@yinghai yinghai commented May 16, 2020

Summary: ATT. NNPI is supporting it yet.

Test Plan:
unittests in the diff

buck test mode/dev //glow/fb/test/numerics:test_fc_nnpi_int8nnpi -- 'test_int8_fc_simple_fp32_bias \(glow\.fb\.test\.numerics\.test_fc_nnpi_int8\.Int8FCTest\)'

Failing with error:

I0407 17:13:45.174736 1553353 NNPIOptions.cpp:49] [NNPI_LOG][E] [GT] fully_connected.cpp(457): GTException raised: ICE-Layers exception: Data type mismatch between
                 tensor1: 'input' and tensor2: 'biases'
 at : /home/engshare/third-party2/fb-nnpi-sw/0.5.1.5/src/nnpi-sw/src/compiler/nnpi_compiler/src/ice_layers/src/fully_connected.cpp:457

Reviewed By: jackm321

Differential Revision: D20474831

Yinghai Lu added 3 commits May 15, 2020 23:14
Differential Revision: D21578777

fbshipit-source-id: d2c0eb150708d0fdc924efde1a98f450be5e2c60
Differential Revision: D21608439

fbshipit-source-id: 2758674f8938fb7894f9accc97e7eb5244161ce3
Summary: ATT. NNPI is supporting it yet.

Test Plan:
unittests in the diff
```
buck test mode/dev //glow/fb/test/numerics:test_fc_nnpi_int8nnpi -- 'test_int8_fc_simple_fp32_bias \(glow\.fb\.test\.numerics\.test_fc_nnpi_int8\.Int8FCTest\)'
```

Failing with error:
```
I0407 17:13:45.174736 1553353 NNPIOptions.cpp:49] [NNPI_LOG][E] [GT] fully_connected.cpp(457): GTException raised: ICE-Layers exception: Data type mismatch between
                 tensor1: 'input' and tensor2: 'biases'
 at : /home/engshare/third-party2/fb-nnpi-sw/0.5.1.5/src/nnpi-sw/src/compiler/nnpi_compiler/src/ice_layers/src/fully_connected.cpp:457
```

Reviewed By: jackm321

Differential Revision: D20474831

fbshipit-source-id: 3938ac00739ea8524cad52555c13e1efd907d0f4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20474831

@dr-ci
Copy link

dr-ci bot commented May 16, 2020

💊 CI failures summary and remediations

As of commit 60e40f5 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 2 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d904f33.

@yinghai yinghai deleted the export-D20474831 branch May 18, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants