Enforce that named_tensor_meta_ is non-null only if there is a non-wildcard name #38725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldcard name Today, there are two equivalent representations: named_tensor_meta_ is null, or named_tensor_meta_ is non-null but all of the dimension names are wildcard. Let's reduce the opportunity for behavior divergence by making the second representation illegal. This will make it easier for me to add a dispatch key for named tensor as I can rely on setters to always go through TensorImpl to maintain invariants on DispatchKey. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 19, 2020
…ldcard name Today, there are two equivalent representations: named_tensor_meta_ is null, or named_tensor_meta_ is non-null but all of the dimension names are wildcard. Let's reduce the opportunity for behavior divergence by making the second representation illegal. This will make it easier for me to add a dispatch key for named tensor as I can rely on setters to always go through TensorImpl to maintain invariants on DispatchKey. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 621506e Pull Request resolved: #38725
💊 CI failures summary and remediationsAs of commit 8970b88 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
…is a non-wildcard name" Today, there are two equivalent representations: named_tensor_meta_ is null, or named_tensor_meta_ is non-null but all of the dimension names are wildcard. Let's reduce the opportunity for behavior divergence by making the second representation illegal. This will make it easier for me to add a dispatch key for named tensor as I can rely on setters to always go through TensorImpl to maintain invariants on DispatchKey. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
zou3519
approved these changes
May 20, 2020
aten/src/ATen/core/NamedTensor.h
Outdated
| // non-wildcard | ||
| struct CAFFE2_API NamedTensorMeta final : public c10::NamedTensorMetaInterface { | ||
| // This enum is to remind people that the invariant on constructors is that | ||
| // the list of dimnames must have at least one non-wilddcard |
There was a problem hiding this comment.
nit: wilddcard -> wildcard
aten/src/ATen/core/NamedTensor.h
Outdated
|
|
||
| void set_names(DimnameList new_names) { | ||
| void check_invariants() const { | ||
| // TORCH_INTERNAL_ASSERT_DEBUG_ONLY( |
There was a problem hiding this comment.
Maybe delete this comment?
…is a non-wildcard name" Today, there are two equivalent representations: named_tensor_meta_ is null, or named_tensor_meta_ is non-null but all of the dimension names are wildcard. Let's reduce the opportunity for behavior divergence by making the second representation illegal. This will make it easier for me to add a dispatch key for named tensor as I can rely on setters to always go through TensorImpl to maintain invariants on DispatchKey. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Today, there are two equivalent representations: named_tensor_meta_ is
null, or named_tensor_meta_ is non-null but all of the dimension names
are wildcard. Let's reduce the opportunity for behavior divergence by
making the second representation illegal.
This will make it easier for me to add a dispatch key for named
tensor as I can rely on setters to always go through TensorImpl to
maintain invariants on DispatchKey.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D21662641