qat syncbn: add test coverage #38738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds test coverage for swapping BN -> SyncBN on a fused ConvBN module. Test Plan: ``` python test/test_quantization.py TestDistributed.test_qat_convbn_fused_syncbn_replacement ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit e6ae36e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
| fused_model.qconfig = torch.quantization.get_default_qconfig('fbgemm') | ||
| torch.quantization.prepare_qat(fused_model, inplace=True) | ||
| # replace with DDP | ||
| fused_model = nn.SyncBatchNorm.convert_sync_batchnorm(fused_model) |
There was a problem hiding this comment.
Does the convert logic need to be modified after training ? How about a test to check that convert works with sync bn module?
There was a problem hiding this comment.
yep, sounds good. let's save that for a separate PR? I don't plan to get to that until we verify SyncBN accuracy with QAT, and it would be great to land this in the meanwhile.
There was a problem hiding this comment.
Sure, approving it now.
raghuramank100
approved these changes
May 20, 2020
Summary: Adds test coverage for swapping BN -> SyncBN on a fused ConvBN module. Test Plan: ``` python test/test_quantization.py TestDistributed.test_qat_convbn_fused_syncbn_replacement ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21648320](https://our.internmc.facebook.com/intern/diff/D21648320) [ghstack-poisoned]
|
This pull request has been merged in 4d5d9c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds test coverage for swapping BN -> SyncBN on a fused ConvBN module.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21648320