Support void return type in TensorIteratorDynamicCasting checks. #38815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CPU kernels have void return types and the currently implementation segfaults on these cases. [ghstack-poisoned]
This was referenced May 20, 2020
💊 CI failures summary and remediationsAs of commit cb528c3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
zasdfgbnm
approved these changes
May 20, 2020
|
Build errors seems to be caused by missing an include |
…hecks." Some CPU kernels have void return types and the currently implementation segfaults on these cases. Differential Revision: [D21670717](https://our.internmc.facebook.com/intern/diff/D21670717) [ghstack-poisoned]
…hecks." Some CPU kernels have void return types and the currently implementation segfaults on these cases. Differential Revision: [D21670717](https://our.internmc.facebook.com/intern/diff/D21670717) [ghstack-poisoned]
…hecks." Some CPU kernels have void return types and the currently implementation segfaults on these cases. Differential Revision: [D21670717](https://our.internmc.facebook.com/intern/diff/D21670717) [ghstack-poisoned]
ngimel
approved these changes
May 21, 2020
…hecks." Some CPU kernels have void return types and the currently implementation segfaults on these cases. Differential Revision: [D21670717](https://our.internmc.facebook.com/intern/diff/D21670717) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some CPU kernels have void return types and the currently implementation segfaults on these cases.
Differential Revision: D21670717