make onnx expect tests resiliant to producer_version changes #39002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
May 26, 2020
|
TBH, it would be better to replace it with some more meaningful signifier, but I won't block the PR on that. |
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2020
Summary: xref gh-39002 which handled the reading but not the writing of the onnx expect files, and the last comment in that PR which points out `XXX` was suboptimal. xref [this comment](#37091 (comment)) which pointed out the problem. This PR: - replaces `XXX` with `CURRENT_VERSION` in the stored files - ensures that updating the results with the `--accept` flag will maintain the change Pull Request resolved: #41910 Reviewed By: pbelevich Differential Revision: D22758671 Pulled By: ezyang fbshipit-source-id: 47c345c66740edfc8f0fb9ff358047a41e19b554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-32561 closes gh-38545. As part of the fallout from gh-36797, this PR
testing/_internal/common_utils.pywith a regex to change the onnx producer_version so tests still passThe consistency of the torch version and the onnx
producer_versionis tested in gh-36797, so there is no reason to test it again in the expect tests.xref gh-38629 which documented how to run the onnx tests and at the same time refactored the Community documentation.