Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
make onnx expect tests resiliant to producer_version changes #39002
The consistency of the torch version and the onnx
xref gh-38629 which documented how to run the onnx tests and at the same time refactored the Community documentation.
Summary: closes gh-32561 closes gh-38545. As part of the fallout from gh-36797, this PR - replaces the producer_version: "1.6" in onnx expect tests with `producer_version: "XXX" - adapts `testing/_internal/common_utils.py` with a regex to change the onnx producer_version so tests still pass The consistency of the torch version and the onnx `producer_version` is tested in gh-36797, so there is no reason to test it again in the expect tests. xref gh-38629 which documented how to run the onnx tests and at the same time refactored the Community documentation. Pull Request resolved: #39002 Differential Revision: D21723062 Pulled By: ezyang fbshipit-source-id: 1bd6a8ed37d5383e69d017226dc09c0645a69aff
Summary: xref gh-39002 which handled the reading but not the writing of the onnx expect files, and the last comment in that PR which points out `XXX` was suboptimal. xref [this comment](#37091 (comment)) which pointed out the problem. This PR: - replaces `XXX` with `CURRENT_VERSION` in the stored files - ensures that updating the results with the `--accept` flag will maintain the change Pull Request resolved: #41910 Reviewed By: pbelevich Differential Revision: D22758671 Pulled By: ezyang fbshipit-source-id: 47c345c66740edfc8f0fb9ff358047a41e19b554