[quant][graphmode][refactor] propagateQuantizationOps #39550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 5, 2020
facebook-github-bot
added
the
oncall: jit
This was referenced Jun 5, 2020
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 794734d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 31 times. |
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 8, 2020
| void propagateDequantize(Value* output, const std::vector<Value*> inputs) { | ||
| Node* n = output->node(); | ||
| Graph* graph = n->owningGraph(); | ||
| void removeDequantizeFromInputs(const std::vector<Value*>& inputs) { |
There was a problem hiding this comment.
Can you add a test showing the functionality here before you land?
There was a problem hiding this comment.
this is a refactor, not a new functionality, it's already tested in test_quantize_script.py
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942063](https://our.internmc.facebook.com/intern/diff/D21942063) [ghstack-poisoned]
supriyar
reviewed
Jun 9, 2020
| for (auto* input : inputs) { | ||
| is_dequantized &= input->node()->kind() == Symbol::aten("dequantize"); | ||
| if (isSingleInputGeneralValueAtenFunction(n)) { | ||
| for (auto* output : n->outputs()) { |
There was a problem hiding this comment.
Do we need this for loop inside the if, else statements? Can it be moved outside?
There was a problem hiding this comment.
yeah, this refactor is preparing for next PR, where we do things differently for the else branch
Summary: This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942063](https://our.internmc.facebook.com/intern/diff/D21942063) [ghstack-poisoned]
|
This pull request has been merged in c902146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
aten::append#39644 [quant][graphmode] Support quantization foraten::appendifin insert_observers #39615 [quant][graphmode] Fix a corner case in handlingifin insert_observersSummary:
This is to prepare for next PR that fixes propagate dequantize for ops with multiple outputs
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21942063